Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eliminate cruft around transparent images once and for all #276

Closed
dankamongmen opened this issue Jan 14, 2020 · 1 comment
Closed

Eliminate cruft around transparent images once and for all #276

dankamongmen opened this issue Jan 14, 2020 · 1 comment
Assignees
@dankamongmen
Labels
bug Something isn't working
Milestone
v1.1.0

Comments

@dankamongmen
Copy link
Owner

Run the view demo. One absolutely sees crufty outlines around the DSSCAW logo that pops up first. I want them gone.
@dankamongmen dankamongmen added the bug Something isn't working label Jan 14, 2020
@dankamongmen dankamongmen added this to the v1.1.0 milestone Jan 14, 2020
@dankamongmen dankamongmen self-assigned this Jan 14, 2020
@dankamongmen
Copy link
Owner Author

Figured it out. ffmpeg has an 8-bit channel of alpha output, but we have two bits. Need to map the full range. I now make [0..127) transparent, and [128..255) not transparent, and things look correct.

dankamongmen added a commit that referenced this issue Jan 15, 2020
@dankamongmen
Map 8-bit ffmpeg α to 2-bit notcurses α #276
d1f2d43
@dankamongmen dankamongmen mentioned this issue Jan 15, 2020
Merged
dankamongmen added a commit that referenced this issue Jan 15, 2020
@dankamongmen
Map 8-bit ffmpeg α to 2-bit notcurses α #276
b8f25ff
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dankamongmen dankamongmen

Labels
bug Something isn't working
Projects
None yet
Milestone
v1.1.0
Development

No branches or pull requests
1 participant
@dankamongmen