Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

some unit tests are breaking when run outside of UTF8 encoding #428

Closed
dankamongmen opened this issue Mar 29, 2020 · 1 comment
Closed

some unit tests are breaking when run outside of UTF8 encoding #428

dankamongmen opened this issue Mar 29, 2020 · 1 comment
Assignees
@dankamongmen
Labels
bug Something isn't working
Milestone
1.3.0

Comments

@dankamongmen
Copy link
Owner

We have enforce_utf8() available in the test suite for anything that requires UTF8 output to work (see #325 ). I don't think everything that needs to is using it, though -- we get test failures running debuild on Ubuntu Focal, and manually setting LANG=C when running unit tests on my box does indeed see some breakage.

Hopefully this doesn't affect the build we put up for Debian (still no word on this from ftpmasters btw). If so, we probably want to rebuild to avoid rejection for being unable to build from source.
@dankamongmen dankamongmen added the bug Something isn't working label Mar 29, 2020
@dankamongmen dankamongmen added this to the 1.3.0 milestone Mar 29, 2020
@dankamongmen dankamongmen self-assigned this Mar 29, 2020
dankamongmen added a commit that referenced this issue Mar 29, 2020
@dankamongmen
Enforce UTF8 where necessary in unit tests #428
a3323fb 
Certain unit tests required UTF8 encoding on the output
terminal to work (#428). This includes anything which does
any kind of fill. Add enforce_utf8() checks to all such
tests that were missing them. Unit tests once again pass in
a pure ASCII environment.
@dankamongmen
Copy link
Owner Author

Looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dankamongmen dankamongmen

Labels
bug Something isn't working
Projects
None yet
Milestone
1.3.0
Development

No branches or pull requests
1 participant
@dankamongmen