Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention rake coverband:clear_tracker in the README #562

Merged
merged 1 commit into from
Oct 19, 2024

Conversation

fatkodima
Copy link
Contributor

It was surprising to find, that rake coverband:clear does not clear trackers data and there is a separate task for it (which is not mentioned anywhere 😅).

I would prefer for clear task to also clear the trackers data, but at least mentioning that task in the README will be good.

@danmayer
Copy link
Owner

good point, could we actually add a clear all that calls all clears, then still have the specific tasks for clearing the coverage and the views, etc...

Then we could also rename the tasks to make more sense in a major release if changing names or adding a namespace, would make things more clear.

@danmayer
Copy link
Owner

also if we want to save all that for later, I am happy to merge this as it is, just let me know your preference @fatkodima

@fatkodima
Copy link
Contributor Author

I think it is ok to merge as it is, and the for a new major version release to have something like:
coverband:clear_coverage - clears only coverage
coverband:clear_tracker - clears only views etc
coverage:clear - clears all

I can create a separate PR (to not forget) that will be sitting until new major release.

@danmayer danmayer merged commit 2d94f5e into danmayer:main Oct 19, 2024
@danmayer
Copy link
Owner

docs in 6.1.4

@fatkodima fatkodima deleted the mention-clear_tracker branch October 19, 2024 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants