Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly manage agg contexts when updating values. #38

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

karanlyons
Copy link
Contributor

Fixes #36.

This is a bit of a messy commit by my own standards, and while I’m somewhat sure it works I’d certainly like to have another set of eyes comb over it before merging.

Adds `.replaceValue` to `AggregationClass` and extends agg contexts with
a pointer to a copy of themselves to store the previous step’s context.

Additionally adds arg `doReplace` to `handleCompaction` to indicate
whether this is a replacement of an existing value, or an append.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant