Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔧 fix: handle missing custom config speech #3790

Merged
merged 2 commits into from
Aug 27, 2024
Merged

🔧 fix: handle missing custom config speech #3790

merged 2 commits into from
Aug 27, 2024

Conversation

berry-13
Copy link
Collaborator

Summary

This PR updates the logic in the Speech component and the getCustomConfigSpeech function to handle the case where the custom configuration is missing. Previously, if no custom configuration was found, an error would occur. Now, the code checks for the presence of the custom configuration and returns a message indicating that no custom configuration was found. This change enhances the robustness of the application and improves the user experience by gracefully handling missing configurations

Change Type

  • Bug fix (non-breaking change which fixes an issue)

Testing

This change was tested by manually simulating the absence of a custom configuration and verifying that the appropriate message is returned without triggering an error. Unit tests were also updated to cover this scenario

Test Configuration:

  • Browser: Chrome, Firefox
  • OS: Windows 11
  • Other Dependencies: None

Checklist

  • My code adheres to this project's style guidelines
  • I have performed a self-review of my own code
  • I have commented in any complex areas of my code
  • I have made pertinent documentation changes
  • My changes do not introduce new warnings
  • I have written tests demonstrating that my changes are effective or that my feature works
  • Local unit tests pass with my changes
  • Any changes dependent on mine have been merged and published in downstream modules
  • A pull request for updating the documentation has been submitted

@berry-13
feat: Update speech settings retrieval logic to handle missing custom…
91699b7 
… configuration

This commit updates the logic in the Speech component and the getCustomConfigSpeech function to handle the case where the custom configuration is missing. Previously, if no custom configuration was found, an error would occur. Now, the code checks for the presence of the custom configuration and returns a message indicating that no custom configuration was found. This improves the robustness of the application and provides a better user experience.
@danny-avila danny-avila merged commit 62881fe into main Aug 27, 2024
4 checks passed
@danny-avila danny-avila deleted the handle-error-get-speech branch August 27, 2024 10:09
kenshinsamue pushed a commit to intelequia/LibreChat that referenced this pull request Sep 17, 2024
@berry-13
🔧 fix: handle missing custom config speech (danny-avila#3790)
1873464 
* feat: Update speech settings retrieval logic to handle missing custom configuration

This commit updates the logic in the Speech component and the getCustomConfigSpeech function to handle the case where the custom configuration is missing. Previously, if no custom configuration was found, an error would occur. Now, the code checks for the presence of the custom configuration and returns a message indicating that no custom configuration was found. This improves the robustness of the application and provides a better user experience.

* refactor: changed response message when no custom config is found
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danny-avila danny-avila danny-avila approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@berry-13 @danny-avila