Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌍 i18n: Updated Chinese Translation #3871

Merged
merged 3 commits into from
Sep 6, 2024
Merged

Conversation

zjjxwhh
Copy link
Contributor

@zjjxwhh zjjxwhh commented Sep 1, 2024

Summary

  1. Recreated the Zh.ts file using the latest Eng.ts file (because the key-value pairs in the original Zh.ts file were completely out of order compared to Eng.ts, making it difficult for me to compare the missing key-value pairs).
  2. Updated the Chinese translations based on the content of the original Zh.ts file.

Since I don't know how to create export const comparisons = {...}, the new Zh.ts file only contains export default {...}. However, I didn't encounter any errors during local testing. If it's necessary, please let me know how to create it. Thank you very much!

Change Type

  • Translation update

Testing

Clone the code, run the backend and frontend, modify Zh.ts, and test.

Checklist

  • My code adheres to this project's style guidelines
  • I have performed a self-review of my own code
  • My changes do not introduce new warnings
  • I have written tests demonstrating that my changes are effective or that my feature works

@zjjxwhh
Copy link
Contributor Author

zjjxwhh commented Sep 1, 2024

May I ask if the "Edge" option under Settings - Speech - Text to Speech - Engine refers to the Microsoft Edge browser? I haven't used Text to Speech before, so I'm not quite sure what it specifically means.

@danny-avila
Copy link
Owner

May I ask if the "Edge" option under Settings - Speech - Text to Speech - Engine refers to the Microsoft Edge browser? I haven't used Text to Speech before, so I'm not quite sure what it specifically means.

Edge refers to cloud edge computing

@danny-avila danny-avila changed the title 🌍 : Updated Chinese Translation 🌍 i18n: Updated Chinese Translation Sep 6, 2024
@danny-avila
Copy link
Owner

thank you for your contribution! let me know if this is ready merge

@zjjxwhh
Copy link
Contributor Author

zjjxwhh commented Sep 6, 2024

@danny-avila Thanks for your explanation. I have updated the corresponding translation and is ready merge.

(Additionally, I noticed that some languages, like Korean, have translated the com_nav_lang_xxx fields. I think these fields should not be translated because it makes it difficult for non-Korean speakers to change the language in the settings, as they may not know that "영어" means "English" and "중국어" means "中文(Chinese).")

@danny-avila
Copy link
Owner

danny-avila commented Sep 6, 2024

(Additionally, I noticed that some languages, like Korean, have translated the com_nav_lang_xxx fields. I think these fields should not be translated because it makes it difficult for non-Korean speakers to change the language in the settings, as they may not know that "영어" means "English" and "중국어" means "中文(Chinese).")

This is true, if you're willing to help with the change, I am very open to changing that. I will merge this and you can open a separate PR for that.

@danny-avila danny-avila merged commit 14199d5 into danny-avila:main Sep 6, 2024
2 checks passed
illgitthat pushed a commit to illgitthat/LibreChat that referenced this pull request Sep 8, 2024
* 👐 a11y: Misc. Improvements (danny-avila#3910)

* fix focus for cancel button in convo delete modal window danny-avila#3829

* add aria-hidden and aria-label to X and Check svg/button respectively and updated OGDialogClose focus color

* update rename, newchat, newchat icon, ConvoOptions icon

* 🌍 i18n: Updated Chinese Translation (danny-avila#3871)

* 🌍 : Updated Chinese Translation

* 🌍 : Updated Chinese Translation

* 🌍 i18n: Update Japanese translation (danny-avila#3877)

* 🌍 i18n: Improved German language translations (danny-avila#3924)

* 🌍 i18n: Improved Portuguese language translations (danny-avila#3947)

Co-authored-by: RaiSantos <itzraisu@gmail.com>

---------

Co-authored-by: Vesna Tan <tanvezi@gmail.com>
Co-authored-by: Hervey <zjjxwhh@163.com>
Co-authored-by: hide361 <180006476+hide361@users.noreply.github.com>
Co-authored-by: Marlon <153027575+marlonka@users.noreply.github.com>
Co-authored-by: Raí Santos <140329135+itzraiss@users.noreply.github.com>
Co-authored-by: RaiSantos <itzraisu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants