Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👓 fix: Assistants Vision Prompt Error Handling (legacy) #4529

Merged
merged 3 commits into from
Oct 23, 2024

Conversation

danny-avila
Copy link
Owner

@danny-avila danny-avila commented Oct 23, 2024

Summary

  • Added a try-catch block to the vision prompt creation in the chatV1 controller to catch and log any errors that occur during this process.
  • Updated the model parameter in the vision prompt creation to use the dynamic model variable instead of the hardcoded 'gpt-4-vision-preview'.
  • Modified the processVisionRequest function in ToolService to check if the completion exists before accessing its usage property, preventing potential undefined errors.
  • Improved code formatting for better readability, particularly in the construction of the additional_instructions string.

Closes #4526

Remember:

  • The Load Balancer should distribute traffic evenly
  • If one droplet goes down, traffic should automatically route to the others
  • You can monitor the Load Balancer metrics in DO dashboard

Would you like me to suggest some specific stress testing tools or show you how to monitor specific metrics?

Checklist

  • My code adheres to this project's style guidelines
  • I have performed a self-review of my own code
  • I have commented in any complex areas of my code
  • My changes do not introduce new warnings
  • I have tested the error handling scenarios
  • Local unit tests pass with my changes

@danny-avila danny-avila merged commit 655f637 into main Oct 23, 2024
1 check failed
@danny-avila danny-avila deleted the fix/legacy-assistants-vision branch October 23, 2024 19:21
owengo pushed a commit to openwengo/LibreChat that referenced this pull request Oct 25, 2024
…4529)

* fix: vision prompt error handling

* fix: Update model reference in chatV1 controller

* remove model reference
danny-avila added a commit that referenced this pull request Oct 27, 2024
* fix: vision prompt error handling

* fix: Update model reference in chatV1 controller

* remove model reference
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Calls to Azure assitants api with vision capabilities cause api server to crash
1 participant