Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 fix: drop reasoning_effort for o1-preview/mini models #5725

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

KiGamji
Copy link
Contributor

@KiGamji KiGamji commented Feb 7, 2025

Summary

Drop reasoning_effort for these models as it only supported for o1-2024-12-17 and above schema.

Change Type

  • Bug fix (non-breaking change which fixes an issue)

@rubentalstra rubentalstra added the 🔧 fix Bug fixes and code patches label Feb 8, 2025
@KiGamji
Copy link
Contributor Author

KiGamji commented Feb 10, 2025

@danny-avila could you review this please? thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔧 fix Bug fixes and code patches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants