Add moduleSearchPaths to preprocessor config
#43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...eventually. More reliable detection of actually-opened documents would make this more reliable, but I'll hold off on that effort pending user feedback.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update adds a new configuration property,
wgsl.preprocessor.moduleSearchPaths. This represents an optional array of additional directories to consider when trying to resolve module imports.Currently, adding an external directory has the unfortunate side effect of reporting errors and warnings from every WGSL document in that directory, regardless of whether they're pertinent to documents in the user's workspace. In VS Code, those diagnostics are eventually pruned, but it takes some time. I don't see this as a huge issue for now, but this can be investigated in the future if it proves to be annoying or problematic for users.