Refactoring and added codeclimate #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Schultzer
force-pushed
the
Refactor-Codeclimate
branch
from
9bb598f
to
4e4f1d7
Compare
Current coverage is 93.37% (diff: 100%)@@ master #21 diff @@
==========================================
Files 3 3
Lines 166 166
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 155 155
Misses 11 11
Partials 0 0
|
Schultzer
force-pushed
the
Refactor-Codeclimate
branch
2 times, most recently
from
dc659a9
to
54df077
Compare
|
Remove code climate and eslint files, and remove codecliamte from readme. |
| @@ -143,21 +143,39 @@ if (env.name !== 'production') { | |||
| app.setPath('userData', userDataPath + ' (' + env.name + ')'); | |||
| } | |||
|
|
|||
| function openWindow(windowName, parentWindow) { | |||
There was a problem hiding this comment.
Why not just make this opts in the first place instead of using parentWindow?
There was a problem hiding this comment.
Actually, all this should be refactored more.
| }); | ||
|
|
||
| it("handles \\t in values", function() { | ||
| it('handles \\t in values', function() { |
There was a problem hiding this comment.
\\t should be changed to \t?
There was a problem hiding this comment.
No. We want to escape the tab in the string for readability.
|
Refactored openWindow method. The rest looks fine. |
|
This is a massive change PR, so we need to merge this in fast. However, we should take some time to see if there's anything that needs to be refactored or cleaned up. |
Schultzer
force-pushed
the
Refactor-Codeclimate
branch
2 times, most recently
from
0cb688e
to
77c25f3
Compare
Removed .eslintrc and .codeclimate.yml
Removed Error: string in title tag it’s shows up twice in tooltip.
Schultzer
force-pushed
the
Refactor-Codeclimate
branch
from
77c25f3
to
8ba83da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Okay. so we need to figure out the rules we should use in our
.eslintrc,.codeclimate.ymlmaybe CSSlint?so we can figure out what we need to refactor and what is not necessary I need @danschultzer your 👀 on that task.
Ruleset for.eslintrcand.codeclimate.yml.eslintrcandcodeclimate.yml'string'for strings in our code baseMove app menu frombackground.jsto it's ownapp_menu_template.js