-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring and added codeclimate #21
Conversation
9bb598f
to
4e4f1d7
Compare
Current coverage is 93.37% (diff: 100%)@@ master #21 diff @@
==========================================
Files 3 3
Lines 166 166
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 155 155
Misses 11 11
Partials 0 0
|
dc659a9
to
54df077
Compare
Remove code climate and eslint files, and remove codecliamte from readme. |
@@ -143,21 +143,39 @@ if (env.name !== 'production') { | |||
app.setPath('userData', userDataPath + ' (' + env.name + ')'); | |||
} | |||
|
|||
function openWindow(windowName, parentWindow) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not just make this opts in the first place instead of using parentWindow
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, all this should be refactored more.
}); | ||
|
||
it("handles \\t in values", function() { | ||
it('handles \\t in values', function() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
\\t
should be changed to \t
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No. We want to escape the tab in the string for readability.
Refactored openWindow method. The rest looks fine. |
This is a massive change PR, so we need to merge this in fast. However, we should take some time to see if there's anything that needs to be refactored or cleaned up. |
0cb688e
to
77c25f3
Compare
Removed .eslintrc and .codeclimate.yml
Removed Error: string in title tag it’s shows up twice in tooltip.
77c25f3
to
8ba83da
Compare
Okay. so we need to figure out the rules we should use in our
.eslintrc
,.codeclimate.yml
maybe CSSlint?so we can figure out what we need to refactor and what is not necessary I need @danschultzer your 👀 on that task.
Ruleset for.eslintrc
and.codeclimate.yml
.eslintrc
andcodeclimate.yml
'string'
for strings in our code baseMove app menu frombackground.js
to it's ownapp_menu_template.js