Added macOS behaviors #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Schultzer
force-pushed
the
macOS-behavior
branch
from
0e555ec
to
cf8c4f2
Compare
When closing all window on macOS should not quit the app. When all window are closed should open new mainWindow when clicked on icon in dock.
Codecov Report
@@ Coverage Diff @@
## master #41 +/- ##
=======================================
Coverage 94.05% 94.05%
=======================================
Files 3 3
Lines 185 185
=======================================
Hits 174 174
Misses 11 11Continue to review full report at Codecov.
|
danschultzer
requested changes
Dec 9, 2016
|
|
||
| app.on('activate', () => { | ||
| if (mainWindow === null) { | ||
| openWindow('main', 'app.html', { width: 640, height: 480 }) |
There was a problem hiding this comment.
This should be moved to a function to prevent duplicate code.
Schultzer
force-pushed
the
macOS-behavior
branch
2 times, most recently
from
35e2d20
to
04ea9fc
Compare
Schultzer
force-pushed
the
macOS-behavior
branch
from
04ea9fc
to
8c4d2d3
Compare
danschultzer
approved these changes
Mar 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When closing all window on macOS should not quit the app.
When all window are closed should open new mainWindow when clicked on icon in dock.