Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make custom redirect_uri_match_fun work with authorization validations #58

Merged

Conversation

davejachimiak
Copy link
Contributor

Working with @blatyo, we discovered that custom
redirect_uri_match_funs were not being invoked during the
authorization phase. This fixes that by passing the config from
RedirectURI.valid_for_authorization? to matches?.

davejachimiak and others added 3 commits August 2, 2019 14:54
Working with @blatyo, we discovered that custom
`redirect_uri_match_fun`s were not being invoked during the
authorization phase. This fixes that by passing the config from
`RedirectURI.valid_for_authorization?` to `matches?`.
@danschultzer
Copy link
Owner

Thanks! I just fixed up this PR by deprecated matches?/2 and returning the test to matches?/3 method since this is where the redirect_uri_match_fun logic is used. The deprecation warning ensures that all methods calls to matches?/3 are correct now, so it's no longer necessary to test valid_for_authorization?.

@danschultzer danschultzer merged commit c9196ee into danschultzer:master Aug 3, 2019
@danschultzer
Copy link
Owner

v0.5.3 released 🚀

@danschultzer
Copy link
Owner

For some reason hex doesn't publish docs, and just returns 502 error. I'll wait an hour and try again.

@danschultzer
Copy link
Owner

v0.5.3 released, hex publish still didn't work properly, but doing mix hex.publish docs after the release properly added the docs.

@davejachimiak
Copy link
Contributor Author

Thanks @danschultzer!

@blatyo
Copy link

blatyo commented Aug 5, 2019

Hey @danschultzer, thanks for this. I just tried to pull 0.5.3 from hex and got:

** (Mix) No matching version for ex_oauth2_provider ~> 0.5.3 (from: mix.exs) in registry

The latest version is: 0.5.2

In the elixir slack hex channel, it seems like they were having issues with the registry over the weekend. They're recommending people publish a new version to get around it.

@danschultzer
Copy link
Owner

Released v0.5.4, and I've retired v0.5.3. Thanks for letting me know 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants