Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Breaking] Change Secrets to AppSettings #258

Closed
dansiegel opened this issue Jul 1, 2021 · 1 comment
Closed

[Breaking] Change Secrets to AppSettings #258

dansiegel opened this issue Jul 1, 2021 · 1 comment
Milestone

Comments

@dansiegel
Copy link
Owner

SUMMARY

Over the years the use of the Secrets API has changed significantly. While some legitimate secrets are included, more often this is really App Settings. In order to better reflect this the API should be updated to reflected it's intent. Additionally the functionality should be expanded to allow you to add multiple generated classes.

DETAILS

First we will need to update the buildtools.json

{
  "appSettings: {
    "projectName": [
      {
        "accessibility": "public",
        "className": "FooBar1",
        "namespace": "Helpers",
        "properties": [
          {
            "name": "Foo",
            "type": "String"
          }
        ]
      }
    ]
  }
}

For those still using projectSecrets this will result in a build warning that projectSecrets are deprecated and will copy it over to the appSettings.

Second while secrets.json will still be supported (with a warning)... we will shift this to instead use appsettings.json. It will continue to be advisable to add this json file to your .gitignore.

PLATFORMS

n/a

@dansiegel dansiegel added this to the v2.0 milestone Jul 1, 2021
@dansiegel
Copy link
Owner Author

closed by #262

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant