Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Secrets to AppSettings #262

Merged
merged 17 commits into from
Jul 5, 2021
Merged

Convert Secrets to AppSettings #262

merged 17 commits into from
Jul 5, 2021

Conversation

dansiegel
Copy link
Owner

Description

This is a major change. Some care has been taken to try to keep the breaks to a minimum with an automatic conversion from the legacy Secrets to the new AppSettings. Note that this is not a simple change from secrets.json to appsettings.json, or from simply having a generated class go from Secrets to AppSettings.

There has been a schema change from projectSecrets to appSettings. Notably, a project can now have many configurations for generated classes. This may be useful for example if you want to generate say an OAuthSettings class and a ApiSettingsClass, etc, in the same project. This will be of more use in a future version of the Mobile.BuildTools once we switch to Roslyn Generation as this will give us the ability to implement interfaces.

Housekeeping

As part of the schema change, the Schema Generator has been reintroduced and the models more completely annotated to assist in an accurate and complete generation.

@dansiegel dansiegel marked this pull request as ready for review July 5, 2021 17:39
@dansiegel dansiegel merged commit 0393c9a into master Jul 5, 2021
@dansiegel dansiegel deleted the bugs/buildtoolsjson branch July 5, 2021 17:39
@dansiegel dansiegel added this to the v2.0 milestone Jul 7, 2021
@tinonetic
Copy link

Hi there,

I am struggling to find documentation for this conversion from secrets.json to appsettings

Any help on where I can find it?

I see one of the samples is still using secrets.json

@bricefriha
Copy link

Thanks for the change @dansiegel, this seems great!
I agree with @tinonetic, it would be nice to help us migrate our code to the new version. I have to keep 1.4 until I find a way to change the secrets.json.

If you explain it, I could maybe create a doc myself if you want 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants