Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sandbox Fixes #143

Merged
merged 15 commits into from
Sep 28, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .editorconfig
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,10 @@ indent_size = 2
[*.xml]
indent_size = 2

# XAML Files
[*.xaml]
indent_size = 2

# Dotnet code style settings:
[*.{cs,vb}]
# Sort using and Import directives with System.* appearing first
Expand Down
4 changes: 3 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -19,4 +19,6 @@ TestResults/
.DS_Store
Thumbs.db

**/Images/**/Thumbs.db
**/Images/**/Thumbs.db

AppPackages/
7 changes: 0 additions & 7 deletions Dependencies.props

This file was deleted.

16 changes: 5 additions & 11 deletions Directory.build.props
Original file line number Diff line number Diff line change
Expand Up @@ -5,22 +5,20 @@
<Copyright>© Dan Siegel</Copyright>
<PackageIconUrl>https://raw.githubusercontent.com/dansiegel/Mobile.BuildTools/master/logo/icon.png</PackageIconUrl>
<PackageIcon>icon.png</PackageIcon>
<DevelopmentDependency>true</DevelopmentDependency>
<PackageLicenseExpression>MIT</PackageLicenseExpression>
<PackageReleaseNotes>https://github.com/dansiegel/Mobile.BuildTools/releases</PackageReleaseNotes>
<PackageProjectUrl>https://mobilebuildtools.com</PackageProjectUrl>
<LocalArtifactStagingDirectory>$([System.IO.Path]::Combine('$(MSBuildThisFileDirectory)', 'Artifacts'))</LocalArtifactStagingDirectory>
<PackageOutputPath Condition=" '$(BUILD_ARTIFACTSTAGINGDIRECTORY)' != '' ">$([System.IO.Path]::Combine('$(BUILD_ARTIFACTSTAGINGDIRECTORY)', 'Artifacts'))</PackageOutputPath>
<PackageOutputPath Condition=" '$(BUILD_ARTIFACTSTAGINGDIRECTORY)' == '' ">$(LocalArtifactStagingDirectory)</PackageOutputPath>
<VersionPrefix>2.0.0</VersionPrefix>
<VersionPrefix Condition=" '$(BUILD_BUILDNUMBER)' != '' ">$(VersionPrefix).$(BUILD_BUILDNUMBER)</VersionPrefix>
<VersionSuffix>ci</VersionSuffix>
<VersionSuffix Condition=" '$(IS_PREVIEW)' == 'true' ">pre</VersionSuffix>
<VersionSuffix Condition=" '$(IS_RELEASE)' == 'true' "></VersionSuffix>
<LangVersion Condition=" '$(OS)' == 'Windows_NT' ">8.0</LangVersion>
<IsPackable>false</IsPackable>
<IncludeSymbols>True</IncludeSymbols>
<SymbolPackageFormat>snupkg</SymbolPackageFormat>
<IncludeSource>True</IncludeSource>
<LangVersion>latest</LangVersion>
<RepositoryType>git</RepositoryType>
<RepositoryUrl>https://github.com/dansiegel/Mobile.BuildTools.git</RepositoryUrl>
<NeutralLanguage>en</NeutralLanguage>
</PropertyGroup>

<!-- CI Helper -->
Expand All @@ -30,10 +28,6 @@
<ContinuousIntegrationBuild>$(CI)</ContinuousIntegrationBuild>
</PropertyGroup>

<PropertyGroup>
<MicrosoftBuildNuGetVersion>16.0.461</MicrosoftBuildNuGetVersion>
</PropertyGroup>

<ItemGroup Condition="$(IsPackable)">
<None Include="$(MSBuildThisFileDirectory)logo\icon.png" Pack="true" PackagePath="\icon.png" />
</ItemGroup>
Expand Down
2 changes: 2 additions & 0 deletions Directory.build.targets
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
<Project>
<Sdk Name="Microsoft.Build.CentralPackageVersions" Version="2.0.79" />

<PropertyGroup>
<Product>$(AssemblyName) ($(TargetFramework))</Product>
Expand All @@ -7,6 +8,7 @@
<Target Name="DeleteCachedPackage" Condition="'$(CI)' != 'true'" BeforeTargets="Pack">
<ItemGroup>
<ToDelete Include="$(PackageOutputPath)\$(PackageId).$(GitBaseVersionMajor).$(GitBaseVersionMinor).$(GitBaseVersionPatch)*.*" />
<ToDelete Include="$(LocalArtifactStagingDirectory)\$(PackageId).$(GitBaseVersionMajor).$(GitBaseVersionMinor).*" />
</ItemGroup>
<Delete Files="@(ToDelete)" />
<Exec Command='rd "$(NuGetPackageRoot)$(PackageId.ToLowerInvariant())" /q /s'
Expand Down
7 changes: 7 additions & 0 deletions E2E/CI.props
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
<Project>
<Import Project="../Directory.Build.props" />
<ItemGroup>
<PackageReference Include="Mobile.BuildTools" VersionOverride="GeneratedPackageVersion" PrivateAssets="all" />
<PackageReference Include="Mobile.BuildTools.Configuration" VersionOverride="GeneratedPackageVersion" />
</ItemGroup>
</Project>
23 changes: 23 additions & 0 deletions E2E/Directory.Build.props
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
<Project>

<Import Project="../Directory.Build.props" />

<PropertyGroup Condition=" '$(PIPELINE_WORKSPACE)' != '' ">
<CIArtifactsDirectory>$([System.IO.Path]::Combine('$(PIPELINE_WORKSPACE)', 'Artifacts'))</CIArtifactsDirectory>
<GeneratedLocalPackage>$([System.IO.Directory]::GetFiles('$(CIArtifactsDirectory)', 'Mobile.BuildTools.2.*.nupkg')[0])</GeneratedLocalPackage>
</PropertyGroup>
<PropertyGroup Condition=" '$(PIPELINE_WORKSPACE)' == '' ">
<GeneratedLocalPackage>$([System.IO.Directory]::GetFiles('$(LocalArtifactStagingDirectory)', 'Mobile.BuildTools.2.*.nupkg')[0])</GeneratedLocalPackage>
</PropertyGroup>

<PropertyGroup>
<GenerateLocalPackageFileName>$([System.IO.Path]::GetFileNameWithoutExtension('$(GeneratedLocalPackage)'))</GenerateLocalPackageFileName>
<GeneratedPackageVersion>$(GenerateLocalPackageFileName.Replace('Mobile.BuildTools.', ''))</GeneratedPackageVersion>
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Mobile.BuildTools" VersionOverride="$(GeneratedPackageVersion)" PrivateAssets="all" />
<PackageReference Include="Mobile.BuildTools.Configuration" VersionOverride="$(GeneratedPackageVersion)" />
</ItemGroup>

</Project>
16 changes: 0 additions & 16 deletions E2E/Directory.build.props

This file was deleted.

2 changes: 1 addition & 1 deletion E2E/E2E.Core/E2E.Core.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Xamarin.Forms" Version="$(XamarinFormsVersion)" />
<PackageReference Include="Xamarin.Forms" />
</ItemGroup>

</Project>
13 changes: 6 additions & 7 deletions E2E/E2E.Tests/E2E.Tests.csproj
Original file line number Diff line number Diff line change
@@ -1,20 +1,19 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>netcoreapp2.1</TargetFramework>
<TargetFramework>netcoreapp3.1</TargetFramework>
<IsPackable>false</IsPackable>
<MobileBuildToolsDebug>true</MobileBuildToolsDebug>
</PropertyGroup>

<!-- <None Include="SampleManifest.json" CopyToOutput> -->

<ItemGroup>
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.4.0" />
<PackageReference Include="Xamarin.Forms" Version="$(XamarinFormsVersion)" />
<PackageReference Include="xunit" Version="2.4.1" />
<PackageReference Include="xunit.runner.visualstudio" Version="2.4.1" />
<DotNetCliToolReference Include="dotnet-xunit" Version="2.3.1" />
<PackageReference Include="Xamarin.Forms.Mocks" Version="3.5.0.2" />
<PackageReference Include="Microsoft.NET.Test.Sdk" />
<PackageReference Include="Xamarin.Forms" />
<PackageReference Include="xunit" />
<PackageReference Include="xunit.runner.visualstudio" />
<PackageReference Include="Xamarin.Forms.Mocks" />
</ItemGroup>

<ItemGroup>
Expand Down
12 changes: 6 additions & 6 deletions E2E/E2EApp/E2EApp.Android/E2EApp.Android.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -49,12 +49,12 @@
<Reference Include="System.Xml" />
</ItemGroup>
<ItemGroup>
<PackageReference Include="Xamarin.Android.Support.Design" Version="28.0.0.3" />
<PackageReference Include="Xamarin.Android.Support.v7.AppCompat" Version="28.0.0.3" />
<PackageReference Include="Xamarin.Android.Support.v4" Version="28.0.0.3" />
<PackageReference Include="Xamarin.Android.Support.v7.CardView" Version="28.0.0.3" />
<PackageReference Include="Xamarin.Android.Support.v7.MediaRouter" Version="28.0.0.3" />
<PackageReference Include="Xamarin.Forms" Version="$(XamarinFormsVersion)" />
<PackageReference Include="Xamarin.Android.Support.Design" />
<PackageReference Include="Xamarin.Android.Support.v7.AppCompat" />
<PackageReference Include="Xamarin.Android.Support.v4" />
<PackageReference Include="Xamarin.Android.Support.v7.CardView" />
<PackageReference Include="Xamarin.Android.Support.v7.MediaRouter" />
<PackageReference Include="Xamarin.Forms" />
</ItemGroup>
<ItemGroup>
<Compile Include="MainActivity.cs" />
Expand Down
17 changes: 2 additions & 15 deletions E2E/E2EApp/E2EApp.Android/Properties/AssemblyInfo.cs
Original file line number Diff line number Diff line change
Expand Up @@ -3,32 +3,19 @@
using System.Runtime.InteropServices;
using Android.App;

// General Information about an assembly is controlled through the following
// General Information about an assembly is controlled through the following
// set of attributes. Change these attribute values to modify the information
// associated with an assembly.
[assembly: AssemblyTitle("E2EApp.Android")]
[assembly: AssemblyDescription("")]
[assembly: AssemblyConfiguration("")]
[assembly: AssemblyCompany("")]
[assembly: AssemblyProduct("E2EApp.Android")]
[assembly: AssemblyCopyright("Copyright © 2014")]
[assembly: AssemblyCopyright("Copyright © Dan Siegel 2020")]
[assembly: AssemblyTrademark("")]
[assembly: AssemblyCulture("")]
[assembly: ComVisible(false)]

// Version information for an assembly consists of the following four values:
//
// Major Version
// Minor Version
// Build Number
// Revision
//
// You can specify all the values or you can default the Build and Revision Numbers
// by using the '*' as shown below:
// [assembly: AssemblyVersion("1.0.*")]
[assembly: AssemblyVersion("1.0.0.0")]
[assembly: AssemblyFileVersion("1.0.0.0")]

// Add some common permissions, these can be removed if not needed
[assembly: UsesPermission(Android.Manifest.Permission.Internet)]
[assembly: UsesPermission(Android.Manifest.Permission.WriteExternalStorage)]
4 changes: 2 additions & 2 deletions E2E/E2EApp/E2EApp.UITests/E2EApp.UITests.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,8 @@
<Reference Include="System" />
</ItemGroup>
<ItemGroup>
<PackageReference Include="NUnit" Version="3.12.0" />
<PackageReference Include="Xamarin.UITest" Version="3.0.3 " />
<PackageReference Include="NUnit" />
<PackageReference Include="Xamarin.UITest" />
</ItemGroup>
<ItemGroup>
<ProjectReference Include="..\E2EApp.iOS\E2EApp.iOS.csproj">
Expand Down
9 changes: 3 additions & 6 deletions E2E/E2EApp/E2EApp.UITests/Tests.cs
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
using System;
using System.Diagnostics;
using System.IO;
using System.Linq;
using NUnit.Framework;
Expand Down Expand Up @@ -51,12 +52,8 @@ public void ClientVersionIsUpdated()

private string GetBuildNumber()
{
if(File.Exists("buildnumber.txt"))
{
return File.ReadAllText("buildnumber.txt");
}

return string.Empty;
var assembly = GetType().Assembly;
return FileVersionInfo.GetVersionInfo(assembly.Location).FileVersion;
}
}
}
1 change: 0 additions & 1 deletion E2E/E2EApp/E2EApp.UITests/buildnumber.txt

This file was deleted.

4 changes: 2 additions & 2 deletions E2E/E2EApp/E2EApp.iOS/E2EApp.iOS.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -114,8 +114,8 @@
<Reference Include="Xamarin.iOS" />
</ItemGroup>
<ItemGroup>
<PackageReference Include="Xamarin.TestCloud.Agent" Version="0.21.9" />
<PackageReference Include="Xamarin.Forms" Version="$(XamarinFormsVersion)" />
<PackageReference Include="Xamarin.TestCloud.Agent" />
<PackageReference Include="Xamarin.Forms" />
</ItemGroup>
<Import Project="$(MSBuildExtensionsPath)\Xamarin\iOS\Xamarin.iOS.CSharp.targets" />
<ItemGroup>
Expand Down
21 changes: 4 additions & 17 deletions E2E/E2EApp/E2EApp.iOS/Properties/AssemblyInfo.cs
Original file line number Diff line number Diff line change
Expand Up @@ -2,35 +2,22 @@
using System.Runtime.CompilerServices;
using System.Runtime.InteropServices;

// General Information about an assembly is controlled through the following
// General Information about an assembly is controlled through the following
// set of attributes. Change these attribute values to modify the information
// associated with an assembly.
[assembly: AssemblyTitle("E2EApp.iOS")]
[assembly: AssemblyDescription("")]
[assembly: AssemblyConfiguration("")]
[assembly: AssemblyCompany("")]
[assembly: AssemblyProduct("E2EApp.iOS")]
[assembly: AssemblyCopyright("Copyright © 2014")]
[assembly: AssemblyCopyright("Copyright © Dan Siegel 2020")]
[assembly: AssemblyTrademark("")]
[assembly: AssemblyCulture("")]

// Setting ComVisible to false makes the types in this assembly not visible
// to COM components. If you need to access a type in this assembly from
// Setting ComVisible to false makes the types in this assembly not visible
// to COM components. If you need to access a type in this assembly from
// COM, set the ComVisible attribute to true on that type.
[assembly: ComVisible(false)]

// The following GUID is for the ID of the typelib if this project is exposed to COM
[assembly: Guid("72bdc44f-c588-44f3-b6df-9aace7daafdd")]

// Version information for an assembly consists of the following four values:
//
// Major Version
// Minor Version
// Build Number
// Revision
//
// You can specify all the values or you can default the Build and Revision Numbers
// by using the '*' as shown below:
// [assembly: AssemblyVersion("1.0.*")]
[assembly: AssemblyVersion("1.0.0.0")]
[assembly: AssemblyFileVersion("1.0.0.0")]
4 changes: 2 additions & 2 deletions E2E/E2EApp/E2EApp/E2EApp.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Xamarin.Essentials" Version="$(XamarinEssentialsVersion)" />
<PackageReference Include="Xamarin.Forms" Version="$(XamarinFormsVersion)" />
<PackageReference Include="Xamarin.Essentials" />
<PackageReference Include="Xamarin.Forms" />
</ItemGroup>

</Project>
22 changes: 4 additions & 18 deletions Mobile.BuildTools.sln
Original file line number Diff line number Diff line change
@@ -1,11 +1,10 @@
Microsoft Visual Studio Solution File, Format Version 12.00

Microsoft Visual Studio Solution File, Format Version 12.00
# Visual Studio Version 16
VisualStudioVersion = 16.0.28803.202
MinimumVisualStudioVersion = 15.0.26124.0
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Mobile.BuildTools", "src\Mobile.BuildTools\Mobile.BuildTools.csproj", "{ECB330A6-90E5-4EF2-8889-86DE2AC0723E}"
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Mobile.BuildTools.CLI", "src\Mobile.BuildTools.CLI\Mobile.BuildTools.CLI.csproj", "{E8B73A93-DB45-42B7-8902-0E0AE945D7BF}"
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Mobile.BuildTools.Configuration", "src\Mobile.BuildTools.Configuration\Mobile.BuildTools.Configuration.csproj", "{25063D4D-2ECC-4B75-98D0-F7B6BAD9D1F7}"
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Mobile.BuildTools.Tests", "tests\Mobile.BuildTools.Tests\Mobile.BuildTools.Tests.csproj", "{22808734-C8D3-431E-AA9A-92432DE4EB6A}"
Expand All @@ -26,9 +25,9 @@ Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Solution Items", "Solution
EndProject
Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "tools", "tools", "{677B710E-6C18-47C0-93B2-A3899370BF5A}"
EndProject
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Mobile.BuildTools.SchemaGenerator", "tools\Mobile.BuildTools.SchemaGenerator\Mobile.BuildTools.SchemaGenerator.csproj", "{B102C625-C640-4E90-B634-CC730140CB7C}"
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Mobile.BuildTools.SchemaGenerator", "tools\Mobile.BuildTools.SchemaGenerator\Mobile.BuildTools.SchemaGenerator.csproj", "{B102C625-C640-4E90-B634-CC730140CB7C}"
EndProject
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Mobile.BuildTools.Reference", "src\Mobile.BuildTools.Reference\Mobile.BuildTools.Reference.csproj", "{20FB88AB-5FE0-41DC-97B7-4C8772A0D059}"
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Mobile.BuildTools.Reference", "src\Mobile.BuildTools.Reference\Mobile.BuildTools.Reference.csproj", "{20FB88AB-5FE0-41DC-97B7-4C8772A0D059}"
EndProject
Global
GlobalSection(SolutionConfigurationPlatforms) = preSolution
Expand All @@ -52,18 +51,6 @@ Global
{ECB330A6-90E5-4EF2-8889-86DE2AC0723E}.Release|x64.Build.0 = Release|Any CPU
{ECB330A6-90E5-4EF2-8889-86DE2AC0723E}.Release|x86.ActiveCfg = Release|Any CPU
{ECB330A6-90E5-4EF2-8889-86DE2AC0723E}.Release|x86.Build.0 = Release|Any CPU
{E8B73A93-DB45-42B7-8902-0E0AE945D7BF}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
{E8B73A93-DB45-42B7-8902-0E0AE945D7BF}.Debug|Any CPU.Build.0 = Debug|Any CPU
{E8B73A93-DB45-42B7-8902-0E0AE945D7BF}.Debug|x64.ActiveCfg = Debug|Any CPU
{E8B73A93-DB45-42B7-8902-0E0AE945D7BF}.Debug|x64.Build.0 = Debug|Any CPU
{E8B73A93-DB45-42B7-8902-0E0AE945D7BF}.Debug|x86.ActiveCfg = Debug|Any CPU
{E8B73A93-DB45-42B7-8902-0E0AE945D7BF}.Debug|x86.Build.0 = Debug|Any CPU
{E8B73A93-DB45-42B7-8902-0E0AE945D7BF}.Release|Any CPU.ActiveCfg = Release|Any CPU
{E8B73A93-DB45-42B7-8902-0E0AE945D7BF}.Release|Any CPU.Build.0 = Release|Any CPU
{E8B73A93-DB45-42B7-8902-0E0AE945D7BF}.Release|x64.ActiveCfg = Release|Any CPU
{E8B73A93-DB45-42B7-8902-0E0AE945D7BF}.Release|x64.Build.0 = Release|Any CPU
{E8B73A93-DB45-42B7-8902-0E0AE945D7BF}.Release|x86.ActiveCfg = Release|Any CPU
{E8B73A93-DB45-42B7-8902-0E0AE945D7BF}.Release|x86.Build.0 = Release|Any CPU
{25063D4D-2ECC-4B75-98D0-F7B6BAD9D1F7}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
{25063D4D-2ECC-4B75-98D0-F7B6BAD9D1F7}.Debug|Any CPU.Build.0 = Debug|Any CPU
{25063D4D-2ECC-4B75-98D0-F7B6BAD9D1F7}.Debug|x64.ActiveCfg = Debug|Any CPU
Expand Down Expand Up @@ -130,7 +117,6 @@ Global
EndGlobalSection
GlobalSection(NestedProjects) = preSolution
{ECB330A6-90E5-4EF2-8889-86DE2AC0723E} = {C7456F1C-2B86-4C40-A228-72209A7355A0}
{E8B73A93-DB45-42B7-8902-0E0AE945D7BF} = {C7456F1C-2B86-4C40-A228-72209A7355A0}
{25063D4D-2ECC-4B75-98D0-F7B6BAD9D1F7} = {C7456F1C-2B86-4C40-A228-72209A7355A0}
{22808734-C8D3-431E-AA9A-92432DE4EB6A} = {2510D213-21AF-4B25-888D-E63163356A4F}
{82EF42A8-49A3-4086-A045-5E2C2F094C04} = {2510D213-21AF-4B25-888D-E63163356A4F}
Expand Down
Loading