Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Horizontal watermark banner is chopped off #208

Conversation

bijington
Copy link
Contributor

Apologies for missing the items in the last PR. This addresses:

  • An error occurring when the scale value is set to 0
  • Watermark Text and Banner will now render at the Top or Bottom correctly. Q: should it have any gap between the top and the banner?

bijington and others added 3 commits April 21, 2021 07:37
Merge from upstream master
- Text and Banner now render correctly at the Top or Bottom
- Add unit test cases for the various watermark position options
- Unit test tweak to the folder naming
@dansiegel dansiegel merged commit bebc5e7 into dansiegel:master Apr 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants