Move app.config props #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dansiegel
force-pushed
the
tasks/configuration-targets
branch
from
6e62c22
to
2e11141
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There is currently a pretty loose connection between Mobile.BuildTools and Mobile.BuildTools.Configuration. This kept all of the build props/targets as part of the Mobile.BuildTools... it also results in a pretty annoying inclusion of the app.config on the iOS/Android project even when the file does not exist. This updates the props so that it is now part of the Configuration project, and you will only get the Include when you actually have the Configuration package referenced.
There isn't really anything I can do for the file showing up. The legacy project sdk's for Android/iOS aren't as capable of dynamic includes like the newer MSBuild Sdks