Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

emacs: explicitly set font size #553

Merged
merged 1 commit into from
Sep 12, 2024
Merged

Conversation

jezcope
Copy link
Contributor

@jezcope jezcope commented Sep 11, 2024

The emacs module currently doesn't set the font size, only the colours and font family. This PR sets it to sizes.terminal (taking a lead from the guifont setting in the vim module) using font-spec, which is a more flexible way to specify fonts in elisp. To indicate the size is points it needs to be a floating point value.

Copy link
Collaborator

@trueNAHO trueNAHO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

If you don't mind, could you include your PR description in the commit message? This would simplify future git log searching/debugging.

The emacs module currently doesn't set the font size, only the colours and font
family. This PR sets it to `sizes.terminal` (taking a lead from the `guifont`
setting in the `vim` module) using `font-spec`, which is a more flexible way to
specify fonts in elisp. To indicate the size is points it needs to be a floating
point value.
@jezcope
Copy link
Contributor Author

jezcope commented Sep 12, 2024

Yup, no problem, done that now. ✅

@trueNAHO trueNAHO merged commit 35233f9 into danth:master Sep 12, 2024
10 checks passed
trueNAHO pushed a commit that referenced this pull request Sep 16, 2024
If the size is expressed as a string, Emacs calls bloody murder:

    invalid font property (:size . "14.000000")

Fixes: 35233f9 ("emacs: explicitly set font size (#553)")

Reviewed-by: Jez Cope <jezcope@users.noreply.github.com>
Approved-by: NAHO <90870942+trueNAHO@users.noreply.github.com>
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants