Add offline support by vendoring webtreemap and using file:// URLs

[insin]

The vendored version of webtreemap is from this PR, which fixes a layout issue and removes the vendor prefix from CSS animation: evmar/webtreemap#2

I've also created an issue to request that webtreemap be published to npm so it doesn't have to be vendored: evmar/webtreemap#7

I'm subscribed to the PR and the issue and am willing to create further PRs to remove vendoring when possible.

Thanks for creating source-map-explorer - I found it invaluable while learning to tame Webpack bundling and continue to do so 👍

[danvk]

will this break on Windows?

[insin]

I wrote it on Windows 😸 Node.js path stuff works fine on Windows if you just use / everywhere, as long as the developers of libs you're using used path.

[danvk]

Thanks for the PR. It looks fine module the comments I left. It would be nice to get your PR merged into webtreemap.

[danvk]

Here's a before / after for this PR on a relatively complex source map. Is this roughly the expected change? Can you summarize what's going on?

[insin]

I assume that's due to the JavaScript tweaks in rmmh/webtreemap@318c345 - you could vendor the original instead until it's published: https://github.com/martine/webtreemap/blob/a5c3115092f3ce97c6544aff4af465a88010f01d/webtreemap.js

I only pulled in the contents from the other PR because I was playing with it locally and it had already removed the CSS vendor prefix on animation.

[danvk]

I understand why the change is happening, I'm just wondering what the
high-level idea behind it is. Are the rectangles more horizontal? Laid out
differently?

On Wed, Jan 13, 2016 at 3:19 PM Jonny Buchanan notifications@github.com
wrote:

I assume that's due to the JavaScript tweaks in rmmh/webtreemap@318c345
rmmh/webtreemap@318c345

• you could vendor the original instead until it's published:
  https://github.com/martine/webtreemap/blob/a5c3115092f3ce97c6544aff4af465a88010f01d/webtreemap.js

I only pulled in the contents from the other PR because I was playing with
it locally and it had already removed the CSS vendor prefix on animation.

—
Reply to this email directly or view it on GitHub
#26 (comment)
.

[danvk]

After playing around with this, I much prefer the newer layout. I'll pull and cut a new release.

Thanks!

[rmmh]

1. it places items largest to smallest, instead of in whatever order the source data has
2. it prefers wide rectangles to tall rectangles, since text is wide, not tall.