Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trim incoming data before trying to parse it as json to make sure there ... #208

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

prusik
Copy link

@prusik prusik commented Apr 14, 2015

...is something to parse.

As context, I need this in an integration with the GetHarvest API, where they use restler but return " " (empty string with space) in their response. Ideally I would prefer that they do the fix on their side, however since it is not open source I feel like this would take forever. I have added the fix and included a test.

issue: #207

thanks!

@ryedog
Copy link

ryedog commented Jul 9, 2015

Wish this would get merged, as having the same issue. @prusik you may want to remove your package.json changes from the PR to make it easier on them (otherwise they have to change it after they merge)

@easternbloc
Copy link
Collaborator

@ryedog I'm afraid it can't get merged until it's been rebased.

Also @prusik if you would like the PR merged please remove the package bump. I'll manage that from this side. THX :)

@prusik
Copy link
Author

prusik commented Jul 9, 2015

Ok so I removed the modifications I made to the package.json. Sorry this was my first pull request. If there is anything else I can do, please let me know.

@easternbloc
Copy link
Collaborator

hi can you just rebase out anything to do with the package.json so to get rid of those last 3 commits do something like:

git rebase -i HEAD~4 then in the interactive rebase delete those 3 commits and save

it should remove them and you can force push the changes back to your repo.

Cheers.

@prusik
Copy link
Author

prusik commented Jul 9, 2015

Sorry but I have no clue how to rebase and have no more time for this now. I did try but was unsuccessful.

@easternbloc
Copy link
Collaborator

No worries. Let me know when you manage to rebase it and I can merge this in. I need to keep the commits clean so it can't go in as it is at the moment I'm afraid.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants