Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added postJson and putJson to the Service wrapper prototype #212

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zipang
Copy link

@zipang zipang commented Jun 11, 2015

The first thig that i tried.... create a service wrapper for a JSON API (which API is not JSON today?) and... bingo.. it was missing..!

The first thig that i tried.... create a service wrapper for a JSON API (which API is not JSON today?) and... bingo.. it was missing..!
@cmhuynh
Copy link

cmhuynh commented Sep 11, 2015

I landed on the main page/documentation and encountered the issue as well.
It costed some investigation into restler source until later I found this bug.

@zipang
Copy link
Author

zipang commented Sep 11, 2015

Did you try my fork for that purpose ?

@cmhuynh
Copy link

cmhuynh commented Sep 12, 2015

My current solution is a common class that extends restler to provide
postJson and putJson.
I intended to made a small contribution back, then I found this PR, so just
comment.
I think this fix worths a review/merge, rather than a fork, in order to fix
the "first impression". The restler documentation shows an example of
postJson that does not exist.
On Sep 12, 2015 3:22 AM, "Christophe Desguez" notifications@github.com
wrote:

Did you try my fork for that purpose ?


Reply to this email directly or view it on GitHub
#212 (comment).

@easternbloc
Copy link
Collaborator

Could you update the docs to list the support of this method?

Can you add a simple test for coverage?

Thanks 🍭

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants