Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOSGCP-86 Add support for advanced networking #30

Merged
merged 2 commits into from
Apr 12, 2022
Merged

DAOSGCP-86 Add support for advanced networking #30

merged 2 commits into from
Apr 12, 2022

Conversation

lsitkiew
Copy link
Contributor

@lsitkiew lsitkiew commented Apr 8, 2022

Signed-off-by: Łukasz Sitkiewicz lukasz.sitkiewicz@intel.com

@lsitkiew
DAOSGCP-86 Add support for advanced networking
415180c 
Signed-off-by: Łukasz Sitkiewicz <lukasz.sitkiewicz@intel.com>
@lsitkiew
Pre-commit changes
4d9de9a 
Signed-off-by: Łukasz Sitkiewicz <lukasz.sitkiewicz@intel.com>
markaolson
markaolson approved these changes Apr 11, 2022
View reviewed changes
Copy link
Contributor

@markaolson markaolson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for converting the packer files to pkr.hcl!
Successfully built images and IO500 images.
Successfully ran IO500 with and without gVNIC enabled.

Kmannth
Kmannth approved these changes Apr 11, 2022
View reviewed changes
Copy link
Contributor

@Kmannth Kmannth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not tested this but the changes look good for me.

Adding Gnvic as a configurable option is a great add.

cboneti
cboneti approved these changes Apr 12, 2022
View reviewed changes
Copy link
Collaborator

@cboneti cboneti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@markaolson markaolson merged commit 24753dd into daos-stack:develop Apr 12, 2022
@lsitkiew lsitkiew deleted the DAOSGCP-86 branch April 13, 2022 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markaolson markaolson markaolson approved these changes

@cboneti cboneti cboneti approved these changes

@Kmannth Kmannth Kmannth approved these changes

@johannlombardi johannlombardi Awaiting requested review from johannlombardi

@iirzynska iirzynska Awaiting requested review from iirzynska

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lsitkiew @markaolson @cboneti @Kmannth