Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOSGCP-111 Remove unneeded Examples #48

Merged
merged 2 commits into from
May 18, 2022
Merged

Conversation

Kmannth
Copy link
Contributor

@Kmannth Kmannth commented May 13, 2022

Enable daos_cluster to be used for all examples.
Setting "client_number_of_instances = 0" allows just
severs to be created.

Only_daos_client has an unclear use. Users should use the
Server output script to install new clients.

Signed-off-by: Keith Mannthey keith.mannthey@intel.com

cboneti
cboneti previously approved these changes May 13, 2022
lsitkiew
lsitkiew previously approved these changes May 16, 2022
Copy link
Contributor

@lsitkiew lsitkiew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me and works correctly.

markaolson
markaolson previously approved these changes May 17, 2022
cboneti
cboneti previously approved these changes May 17, 2022
   Enable daos_cluster to be used for all examples.
   Setting "client_number_of_instances = 0" allows just
   severs to be created.

   Only_daos_client has an unclear use.  Users should use the
   Server output script to install new clients.

Signed-off-by: Keith Mannthey <keith.mannthey@intel.com>
  more tested needed to move the index to 0.

  The current DAOS configs are 3%

Signed-off-by: Keith Mannthey <keith.mannthey@intel.com>
@markaolson markaolson self-requested a review May 18, 2022 17:12
@markaolson markaolson merged commit 2614999 into daos-stack:develop May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants