Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Terraform code to dedicated directory and add main.tf in it #6

Merged
merged 3 commits into from
Oct 15, 2021

Conversation

lsitkiew
Copy link
Contributor

@lsitkiew lsitkiew commented Oct 6, 2021

Signed-off-by: Łukasz Sitkiewicz lukasz.sitkiewicz@intel.com

Signed-off-by: Łukasz Sitkiewicz <lukasz.sitkiewicz@intel.com>
@johannlombardi
Copy link
Contributor

@cboneti any thoughts on this PR? It is very much related to Terraform and i am out of my depth here:)
Thanks in advance.

iirzynska
iirzynska previously approved these changes Oct 7, 2021
Copy link
Contributor

@iirzynska iirzynska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I run it on GCP, after setting up proper project info, all works well.

@lsitkiew lsitkiew requested a review from Kmannth October 7, 2021 15:03
@Kmannth
Copy link
Contributor

Kmannth commented Oct 8, 2021

@lsitkiew There was some discussion today about this approach. The general consensus was there should not be a main.tf for full system setup. If will be best to keep all things modular and composable for future use. In the examples dir it would best to have a few components like:

deploy-performance-server
deploy-capacity-server
deploy-clients
full_cluster_setup (that calls the other modules)
run_io500 (that runs after servers/clients are setup) (this can be bash or ansible)

Please try and move the full main.tf steps into the examples directory and refactor it into full_cluster_setup.

@cboneti
Copy link
Collaborator

cboneti commented Oct 11, 2021

Hey folks, I am really sorry for making you wait here. I second what Keith just said, avoiding having a top level main and, instead, having a folder with modules and another with examples. Here are two examples:
https://github.com/terraform-google-modules/terraform-google-vm
https://github.com/SchedMD/slurm-gcp/tree/master/tf

Signed-off-by: Łukasz Sitkiewicz <lukasz.sitkiewicz@intel.com>
cboneti
cboneti previously approved these changes Oct 11, 2021
Copy link
Collaborator

@cboneti cboneti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

terraform/examples/full_cluster_setup/README.md Outdated Show resolved Hide resolved
Signed-off-by: Łukasz Sitkiewicz <lukasz.sitkiewicz@intel.com>
Copy link
Collaborator

@cboneti cboneti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Kmannth Kmannth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this request on my system and it worked fine. It took me a bit to get terraform.tfvars correctly setup for my setup but docs will help. I can help with the docs in a future submission.

@johannlombardi johannlombardi merged commit 8b4c466 into master Oct 15, 2021
@johannlombardi johannlombardi deleted the terraform branch October 15, 2021 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants