Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-9507 Modifications for DAOS v2.0 #9

Merged
merged 5 commits into from
Jan 14, 2022
Merged

Conversation

markaolson
Copy link
Contributor

@markaolson markaolson commented Jan 8, 2022

Changed image build scripts to install and configure
DAOS v2.0. Image scripts no longer install IO500 in the daos-client images.

Image family name now includes OS of source image. (Ex. daos-server-centos-7)

Changed IO500 install script to install IO500 SC21.

Updated terraform/examples/io500 to use new os image family
names and run IO500 SC21.

Refactored env variable names to be more obvious about what
they are used for.

In many of the bash scripts echo statements with a call to a log function which prints colored boxes. This was done to easily distinguish those messages from large amounts of text in the output from the bash scripts.

README.md files updated to reflect changes listed above.

Signed-off-by: Mark A. Olson mark.a.olson@intel.com

Changed image build scripts to install and configure
DAOS v2.0.

Image family name now includes OS. (Ex. daos-server-centos7)

Changed IO500 install script to install IO500 SC21.

Updated terraform/examples/io500 to use new os image family
names and run IO500 SC21.

Refactored env variable names to be more obvious about what
they are used for.

Signed-off-by: Mark A. Olson <mark.a.olson@intel.com>
johannlombardi
johannlombardi previously approved these changes Jan 10, 2022
Accidentally checked the file in with user specific info.
This change corrects that.

Signed-off-by: Mark A. Olson <mark.a.olson@intel.com>
Set the default disk count for the DAOS server configuration
back to 8.

Signed-off-by: Mark A. Olson <mark.a.olson@intel.com>
cboneti
cboneti previously approved these changes Jan 11, 2022
Copy link
Collaborator

@cboneti cboneti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Please see two minor questions.

images/daos-client-image.json Outdated Show resolved Hide resolved
images/daos-client-image.json Outdated Show resolved Hide resolved
Image names and image family now include the name of the source image.

Signed-off-by: Mark A. Olson <mark.a.olson@intel.com>
No longer installing IO500 in client images.
mpifileutils and IO500 SC21 will now be installed prior
to running the IO500 benchmark.

The cleanup step that runs before an IO500 run will now
set nr_hugepages in daos_server.yml

Logging improvements.

Signed-off-by: Mark A. Olson <mark.a.olson@intel.com>
@markaolson markaolson marked this pull request as ready for review January 13, 2022 02:21
@johannlombardi johannlombardi merged commit 7d077d8 into master Jan 14, 2022
@johannlombardi johannlombardi deleted the DAOS-9507_v2_updates branch January 14, 2022 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants