[WIP] upgrade web3

[jellegerbrandy]

This PR is failing because of this issue in ganache: trufflesuite/ganache#339

[ellis2323]

Is there any progress ? I tried too but without success.

In my case, the sendTransaction is blocking.

let provider = ganache.provider()
web3 = new Web3(provider)
await web3.eth.sendTransaction({ from: ACCOUNTS[0], to: ACCOUNTS[1], value: 1 })

With this version:

    web3.eth.sendTransaction({ from: ACCOUNTS[0], to: ACCOUNTS[1], value: 1 })
      .once('transactionHash', function (hash) { console.log('transactionHash') })
      .once('receipt', function (receipt) { console.log('receipt') })
      .on('confirmation', function (confNumber, receipt) { console.log('confirmation') })
      .on('error', function (error) { console.log('error', error) })
      .then(function (receipt) {
        // will be fired once the receipt is mined
        console.log('mined', receipt)
      })

I see these messages:

transactionHash
confirmation
confirmation

So, to have the same behaviour, i could define options in provider:

let web3 = new Web3(provider, null, { transactionConfirmationBlocks: 1 })

[jellegerbrandy]

obsolete, will create a new one