Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add SimpleSchemeConstraint.sol #803

Merged
merged 3 commits into from
Nov 9, 2020
Merged

add SimpleSchemeConstraint.sol #803

merged 3 commits into from
Nov 9, 2020

Conversation

orenyodfat
Copy link
Contributor

  • Add descriptionHash to SchemeConstraint.sol interface.
    This can be use to give more details description on the constraints which can be used by the UI.,
    (e.g IPFS file ..which give info re white list contracts names, Abis..)
  • Add SimpleSchemeConstraint.sol with only white list contract contraints.

@orenyodfat orenyodfat requested a review from leviadam as a code owner November 9, 2020 08:55
@orenyodfat orenyodfat requested review from ben-kaufman and removed request for leviadam November 9, 2020 08:55
ben-kaufman
ben-kaufman approved these changes Nov 9, 2020
View reviewed changes
Copy link
Contributor

@ben-kaufman ben-kaufman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good to me, just need to fix coverage

@orenyodfat orenyodfat merged commit badb64f into master Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ben-kaufman ben-kaufman ben-kaufman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@orenyodfat @ben-kaufman