add 'reserve' variable instead of hard coded gas of 5000 for delegatecall

[r001]

Minor update to add variable instead of hard coded gas value in delegatecall.

[rainbreak]

To clarify: this is to future proof ds-proxy against gas pricing changes in the EVM.

@gbalabasquer @NiklasKunkel want to restate any opinions here?

[gbalabasquer]

I'd merge this. I hope the gas prices do not change enough to over pass the 5000, otherwise we will be in a trouble. Then I say in a nice thing to have. My only question would be if there is any added value to declare the variable as uint128 instead of uint256.

[NiklasKunkel]

The 5000 gas is so far over the current actual cost that it should be immune to future restructuring of gas prices.

…

On Sat, Nov 24, 2018 at 8:13 AM Gonzalo Balabasquer < ***@***.***> wrote: I'd merge this. I hope the gas prices do not change enough to over pass the 5000, otherwise we will be in a trouble. Then I say in a nice thing to have. My only question would be if there is any added value to declare the variable as uint128 instead of uint256. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#13 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABu7vdx48GqXQpvg0FgZ2MtSzSUddbE6ks5uyXAdgaJpZM4Qh-8j> .

[gbalabasquer]

Yeah I guess the 4200 gas gap should be more than enough, however should it hurt somehow to have it manageable?