Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solc 0.6.x version #26

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

solc 0.6.x version #26

wants to merge 2 commits into from

Conversation

MrChico
Copy link
Member

@MrChico MrChico commented Mar 25, 2020

WARNING: merging will break backwards compatibility with solc < 0.6.

@Yorkemartin
Copy link

hey there - is this PR functional (apart from breaking backwards compatibility with < 0.6) or still a WIP?

@MrChico
Copy link
Member Author

MrChico commented Nov 22, 2020

Yeah, it should be more or less semantically equivalent

* Upgrade dependencies (#29)

* dapp upgrade ds-test

* dapp upgrade ds-auth

* dapp upgrade ds-note

* Remove warnings
@@ -15,7 +15,7 @@
// You should have received a copy of the GNU General Public License
// along with this program. If not, see <http://www.gnu.org/licenses/>.

pragma solidity >=0.5.0 <0.6.0;
pragma solidity >=0.6.0;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should set a higher bound, since the contract doesn't compile with solidity 0.8 for example (due to the cast in line 113)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants