Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address Comments and Cleanup Spec #4

Merged
merged 2 commits into from
Mar 20, 2024
Merged

Conversation

ethDreamer
Copy link

Biggest change here was just moving the mutation of the state out of get_expected_withdrawals()

@ethDreamer
Copy link
Author

Okay I think there was also a bug in process_pending_balance_deposits where it would effectively only function as a rate limiter at the start of the fork and never again. I've updated it based on what I think was the intended logic..

Copy link
Owner

@dapplion dapplion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes! process_pending_balance_deposits is easier to read now too

@dapplion dapplion merged commit 7c9fc19 into dapplion:eip-7251 Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants