Implement servername env and random generator and emit such metric #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dappnodedev
approved these changes
Apr 1, 2024
pablomendezroyo
changed the title
Marketen
reviewed
Apr 2, 2024
| "labels": { | ||
| "job": "api-ui" | ||
| }, | ||
| "targets": ["api-ui.ethical-metrics.dappnode:9090"] |
There was a problem hiding this comment.
why send the server name metric to DMS?
There was a problem hiding this comment.
to allow easy data filtering by server name label, and not only tor instance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User would be allowed to set the server name desired for its instance so its human readable (not like the tor instance
...onion:9090). This parameter can be set throug the package config envSERVER_NAME.If no
SERVER_NAMEis defined then it will be created determinastically a random name using as seed the tor instance and the libunique-names-generatorFurthermore, this servername will be posted in the dappmanager package info view
There will be exposed a new metric containing the servername and tor instance as labels