Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ethical metrics changes #1895

Merged
merged 4 commits into from
Mar 20, 2024
Merged

Ethical metrics changes #1895

merged 4 commits into from
Mar 20, 2024

Conversation

mateumiralles
Copy link
Contributor

@mateumiralles mateumiralles commented Mar 19, 2024 •
edited
Loading

  • Db key notifications instead of ethical-metrics
  • onboarding ethical metrics modal retriggered

System / Notifications

  • Same switch as used in onboarding modal
  • UI data removed when disabling ethical metrics
  • Disabling switch when ANY regex validation fails
  • Layout changed
  • Message displayed when Switch is off to guide the user
  • Confirmation popUp when disabling ethical metrics
  • Notifications copy updated

@mateumiralles mateumiralles requested a review from a team as a code owner March 19, 2024 14:26
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 19, 2024 •
edited
Loading

🚀 Deployed on https://65f9b8c6f590c81573290834--objective-borg-9eeae5.netlify.app

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 19, 2024 •
edited
Loading

DAppNode bot has built and pinned the release to an IPFS node, for commit: 3fe1dc7

This is a development version and should only be installed for testing purposes, install link

/ipfs/QmccAZnQusRvoXcyJ7ZstekarFaWyMyaPgwpvpFPU57Voi

(by dappnodebot/build-action)

@github-actions github-actions bot temporarily deployed to commit March 19, 2024 15:34 Inactive
@github-actions github-actions bot temporarily deployed to commit March 19, 2024 16:09 Inactive
@mateumiralles mateumiralles changed the title Ethical metrics System / Notification changes Ethical metrics changes Mar 19, 2024
@mateumiralles mateumiralles merged commit 2aee5a9 into mateu/telegram-channel-id-input Mar 20, 2024
8 checks passed
@mateumiralles mateumiralles deleted the mateu/system-notifications-modified branch March 20, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mateumiralles