-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New CLI version is very slow on Windows #937
Comments
/assign |
Some more findings:
A major change from v1.6.0 to v1.7.0-rc.2 was Go upgrade from 1.16 to 1.17. |
Confirmed that there is no slowness on Linux or Mac On both M1 Arm Mac with Arm64 binaries and Linux with AMD64 binaries CLI 1.7.0-rc.2 is not any slower than CLI 1.6.0. I went through GitHub bisect also.. but there are no noteworthy differences. |
Please also consider that the Go version used to compile may be a culprit here. As of 2 days ago Windows binaries are compiled with 1.17.8, before that it was 1.17.7. CLI 1.6.0 was compiled with a different version altogether. If Go version can be ruled out (by compiling 1.6.0 again with 1.17.8), use Git Bisect to find the offending commit: git checkout v1.7.0-rc.2
make
# time the following
./dist/..../dapr.exe --version
git bisect start
git bisect good v1.6.0
git bisect bad v1.7.0-rc.2
# now git will suggest a commit
make
# time the following
./dist/..../dapr.exe --version
# now decide if the numbers are good or bad and tell git bisect. For example bad:
git bisect bad
# now git will suggest a new commit etc etc |
The problem is with the go compiler version. I tried using different compiler versions with different CLI versions and here are the results (100 runs per command)
Now, CLI v1.7.0 cannot be downgraded to use go 1.16 because of a pkg dependency introduced by #894. See kubernetes-sigs/controller-tools#643. |
Phew, test results from a brand-new Windows VM: ############################
dapr --version
############################
v1.6.0 release version, compiled with go 1.16
Avg: 155.8055ms
Min: 134.0364ms
Max: 218.5515ms
v1.7.0 release version, compiled with go 1.17
Avg: 125.6285ms
Min: 110.9377ms
Max: 160.8203ms
############################
dapr help
############################
v1.6.0 release version, compiled with go 1.16
Avg: 150.4167ms
Min: 129.6965ms
Max: 256.1846ms
v1.7.0 release version, compiled with go 1.17
Avg: 123.6194ms
Min: 110.8603ms
Max: 159.5841ms The problem was likely with my computer, which had tons of software running. Closing this issue! |
Dapr CLI v1.7.0-rc.2 is considerably slower than v1.6.0 on Windows.
Script used: https://gist.github.com/shubham1172/80846320d8a33bd4a39f65edd9177133
Release Note
RELEASE NOTE: FIX Performance on Windows
The text was updated successfully, but these errors were encountered: