-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade helm version to meet compliance #894
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm @yaron2 Please take a look at this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shubham1172 Can you take a look at this?
@mukundansundar, it looks related to kubernetes-sigs/json#8. Let me check on how to get past it. |
go.mod
Outdated
k8s.io/apimachinery v0.20.2 | ||
k8s.io/cli-runtime v0.20.2 | ||
k8s.io/client-go v0.20.2 | ||
helm.sh/helm/v3 v3.8.0-rc.1.0.20220215042704-bc2f1e08a43a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shubham1172 Is your commit the only change from the last release (3.8.0)? If not we have changes in the client which are not yet released right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mukundansundar, I don't think so. This points to my commit hash, which has a delta of around 27 commits after v3.8.0.
If not we have changes in the client which are not yet released right?
Can you please clarify on this part, I did not get it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if there are more commits after the 3.8 release than the single commit that you made, we have unreleased code also as part of the client right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's true. Their next release is 3.8.1 on March 09, so we can choose to wait as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's wait.
a9aa079
to
5a8c331
Compare
Codecov Report
@@ Coverage Diff @@
## master #894 +/- ##
=======================================
Coverage 22.95% 22.95%
=======================================
Files 29 29
Lines 1616 1616
=======================================
Hits 371 371
Misses 1194 1194
Partials 51 51
Continue to review full report at Codecov.
|
25d54d4
to
a6dd0b3
Compare
Created an issue with helm/helm to check more on this helm/helm#10683 |
Signed-off-by: Shubham Sharma <shubhash@microsoft.com>
a6dd0b3
to
012589f
Compare
Signed-off-by: Shubham Sharma <shubhash@microsoft.com>
Signed-off-by: Shubham Sharma <shubhash@microsoft.com>
/cc @mukundansundar the helm issue has been solved with a workaround. There was a bug introduced in v3.8.0 that caused it. I will update this PR to point to v3.8.1 once it's released. |
Signed-off-by: Shubham Sharma <shubhash@microsoft.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@yaron2 Please take a look.
Signed-off-by: Shubham Sharma shubhash@microsoft.com
Description
This PR upgrades the version of https://github.com/helm/helm to v3.8.1, which contains compliant dependencies per CNCF guidelines.
Commands run:
go get -u helm.sh/helm/v3 go mod tidy -go=1.16 && go mod tidy -go=1.17
Issue reference
Please reference the issue this PR will close: dapr/dapr#4219
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: