Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade helm version to meet compliance #894

Merged
merged 5 commits into from
Mar 11, 2022

Conversation

shubham1172
Copy link
Member

@shubham1172 shubham1172 commented Feb 15, 2022

Signed-off-by: Shubham Sharma shubhash@microsoft.com

Description

This PR upgrades the version of https://github.com/helm/helm to v3.8.1, which contains compliant dependencies per CNCF guidelines.

Commands run:

go get -u helm.sh/helm/v3
go mod tidy -go=1.16 && go mod tidy -go=1.17

Issue reference

Please reference the issue this PR will close: dapr/dapr#4219

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • (NA) Created/updated tests
  • (NA) Extended the documentation

@shubham1172 shubham1172 requested review from a team as code owners February 15, 2022 13:10
@shubham1172 shubham1172 changed the title Upgrade helm version to meet compliance. Upgrade helm version to meet compliance Feb 15, 2022
Copy link
Collaborator

@mukundansundar mukundansundar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm @yaron2 Please take a look at this.

Copy link
Collaborator

@mukundansundar mukundansundar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shubham1172 Can you take a look at this?

@shubham1172
Copy link
Member Author

@mukundansundar, it looks related to kubernetes-sigs/json#8. Let me check on how to get past it.

go.mod Outdated
k8s.io/apimachinery v0.20.2
k8s.io/cli-runtime v0.20.2
k8s.io/client-go v0.20.2
helm.sh/helm/v3 v3.8.0-rc.1.0.20220215042704-bc2f1e08a43a
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shubham1172 Is your commit the only change from the last release (3.8.0)? If not we have changes in the client which are not yet released right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mukundansundar, I don't think so. This points to my commit hash, which has a delta of around 27 commits after v3.8.0.

If not we have changes in the client which are not yet released right?

Can you please clarify on this part, I did not get it.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if there are more commits after the 3.8 release than the single commit that you made, we have unreleased code also as part of the client right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's true. Their next release is 3.8.1 on March 09, so we can choose to wait as well.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's wait.

@codecov
Copy link

codecov bot commented Feb 17, 2022

Codecov Report

Merging #894 (cca1f68) into master (9472e6d) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #894   +/-   ##
=======================================
  Coverage   22.95%   22.95%           
=======================================
  Files          29       29           
  Lines        1616     1616           
=======================================
  Hits          371      371           
  Misses       1194     1194           
  Partials       51       51           
Impacted Files Coverage Δ
pkg/kubernetes/kubernetes.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9472e6d...cca1f68. Read the comment docs.

@shubham1172
Copy link
Member Author

Created an issue with helm/helm to check more on this helm/helm#10683

@shubham1172 shubham1172 changed the title Upgrade helm version to meet compliance [Blocked] Upgrade helm version to meet compliance Feb 17, 2022
Signed-off-by: Shubham Sharma <shubhash@microsoft.com>
Signed-off-by: Shubham Sharma <shubhash@microsoft.com>
Signed-off-by: Shubham Sharma <shubhash@microsoft.com>
@shubham1172
Copy link
Member Author

/cc @mukundansundar the helm issue has been solved with a workaround. There was a bug introduced in v3.8.0 that caused it. I will update this PR to point to v3.8.1 once it's released.

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>
@shubham1172 shubham1172 changed the title [Blocked] Upgrade helm version to meet compliance Upgrade helm version to meet compliance Mar 10, 2022
Copy link
Collaborator

@mukundansundar mukundansundar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yaron2 Please take a look.

@yaron2 yaron2 merged commit 0eda01b into dapr:master Mar 11, 2022
@mukundansundar mukundansundar added this to the v1.7 milestone Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Track dependency updates for armon/consul-api to meet compliance requirements
3 participants