generated from kubernetes/kubernetes-template-project
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Project support for Go 1.16 #8
Comments
Opened #9 to be explicit about the go1.17 requirement |
given go1.16 has just a few weeks of lifetime left before go1.18 is released, I'd prefer to simply be explicit about the go1.17 requirement |
Thanks 🙏 |
Is this supposed to prevent people from being able to install on go 1.16? I think I was still able to and as a result my program won't work until I upgrade to go 1.17. |
7 tasks
This was referenced Jan 25, 2022
brantk-hpe
pushed a commit
to Cray-HPE/postgres-operator
that referenced
this issue
Jan 26, 2022
The build doesn't work with go version 1.16.9. The build was failing with ``` [2022-01-25T22:54:22.534Z] vendor/sigs.k8s.io/json/internal/golang/encoding/json/encode.go:1249:12: sf.IsExported undefined (type reflect.StructField has no field or method IsExported) ``` Looking at bugs like kubernetes-sigs/json#8 it says that go 1.16 is on its way out. The latest 1.17 is 1.17.6, see https://go.dev/doc/devel/release#go1.17.minor
brantk-hpe
pushed a commit
to Cray-HPE/postgres-operator
that referenced
this issue
Jan 26, 2022
The build doesn't work with go version 1.16.9. The build was failing with ``` [2022-01-25T22:54:22.534Z] vendor/sigs.k8s.io/json/internal/golang/encoding/json/encode.go:1249:12: sf.IsExported undefined (type reflect.StructField has no field or method IsExported) ``` Looking at bugs like kubernetes-sigs/json#8 it says that go 1.16 is on its way out. The latest 1.17 is 1.17.6, see https://go.dev/doc/devel/release#go1.17.minor
brantk-hpe
pushed a commit
to Cray-HPE/postgres-operator
that referenced
this issue
Jan 26, 2022
The build doesn't work with go version 1.16.9. The build was failing with ``` [2022-01-25T22:54:22.534Z] vendor/sigs.k8s.io/json/internal/golang/encoding/json/encode.go:1249:12: sf.IsExported undefined (type reflect.StructField has no field or method IsExported) ``` Looking at bugs like kubernetes-sigs/json#8 it says that go 1.16 is on its way out. The latest 1.17 is 1.17.6, see https://go.dev/doc/devel/release#go1.17.minor
brantk-hpe
pushed a commit
to Cray-HPE/postgres-operator
that referenced
this issue
Jan 26, 2022
The build doesn't work with go version 1.16.9. The build was failing with ``` [2022-01-25T22:54:22.534Z] vendor/sigs.k8s.io/json/internal/golang/encoding/json/encode.go:1249:12: sf.IsExported undefined (type reflect.StructField has no field or method IsExported) ``` Looking at bugs like kubernetes-sigs/json#8 it says that go 1.16 is on its way out. The latest 1.17 is 1.17.6, see https://go.dev/doc/devel/release#go1.17.minor
simu
added a commit
to appuio/component-appuio-cloud
that referenced
this issue
Feb 4, 2022
Update go.mod to require go 1.17, since the kubernetes-sigs/json package used by K8s 1.23 uses a go 1.17 feature, cf. kubernetes-sigs/json#8
simu
added a commit
to appuio/component-appuio-cloud
that referenced
this issue
Feb 4, 2022
Update go.mod to require go 1.17, since the kubernetes-sigs/json package used by K8s 1.23 uses a go 1.17 feature, cf. kubernetes-sigs/json#8
maiqueb
added a commit
to maiqueb/whereabouts
that referenced
this issue
Feb 7, 2022
Bumping to k8s 1.23.3 requires the golang version to be bumped up to 1.17, since the json version it uses relies on functionality added in it. [0] - kubernetes-sigs/json#8 Signed-off-by: Miguel Duarte Barroso <mdbarroso@redhat.com>
maiqueb
added a commit
to maiqueb/whereabouts
that referenced
this issue
Feb 7, 2022
Bumping to k8s 1.23.3 requires the golang version to be bumped up to 1.17, since the json version it uses relies on functionality added in it. [0] - kubernetes-sigs/json#8 Signed-off-by: Miguel Duarte Barroso <mdbarroso@redhat.com>
1 task
martin-g
added a commit
to martin-g/volcano
that referenced
this issue
Feb 22, 2022
Related-to: kubernetes-sigs/json#8 Related-to: kubernetes-sigs/controller-tools#643 Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
martin-g
added a commit
to martin-g/volcano
that referenced
this issue
Feb 23, 2022
Related-to: kubernetes-sigs/json#8 Related-to: kubernetes-sigs/controller-tools#643 Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
estahn
added a commit
to estahn/k8s-image-swapper
that referenced
this issue
Sep 7, 2022
estahn
added a commit
to estahn/k8s-image-swapper
that referenced
this issue
Sep 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently, this project is advertised as supporting Go 1.16 in the project go.mod. However, the project uses functionality introduced in Go 1.17 (1, 2) that does not exist in Go 1.16. This is resulting in downstream packages breaking when trying to build with Go 1.16 and the Go module system not detecting the incompatibility.
Ideally this project would support Go 1.16 as it is still a supported version by the Go language maintainers. If that is not possible, it makes sense to bump the minimum version of Go supported in the main
go.mod
to allow these errors to be caught by go tooling.The text was updated successfully, but these errors were encountered: