Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify go1.17 is required #9

Merged
merged 1 commit into from
Dec 8, 2021
Merged

Clarify go1.17 is required #9

merged 1 commit into from
Dec 8, 2021

Conversation

liggitt
Copy link
Contributor

@liggitt liggitt commented Dec 8, 2021

Fixes #8

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 8, 2021
@k8s-ci-robot k8s-ci-robot requested a review from deads2k December 8, 2021 19:52
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from lavalamp December 8, 2021 19:52
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 8, 2021
@liggitt liggitt mentioned this pull request Dec 8, 2021
Closed
@deads2k
Copy link

deads2k commented Dec 8, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 8, 2021
@k8s-ci-robot k8s-ci-robot merged commit 9f7c6b3 into kubernetes-sigs:main Dec 8, 2021
@bittrance bittrance mentioned this pull request Jan 13, 2022
Closed
naemono added a commit to naemono/cloud-on-k8s that referenced this pull request Jan 20, 2022
@naemono
Move fully to golang 1.17
c5f1223 
  note: kubernetes-sigs/json#9
  We are using controller-tools v0.8.0, which includes this as a dependency
  which requires 1.17
@naemono naemono mentioned this pull request Jan 20, 2022
Merged
naemono added a commit to elastic/cloud-on-k8s that referenced this pull request Jan 24, 2022
@naemono
Move fully to golang 1.17 (#5271)
83992f5 
note: kubernetes-sigs/json#9
  We are using controller-tools v0.8.0, which includes this as a dependency
  which requires 1.17
@philipgough philipgough mentioned this pull request Mar 10, 2022
Closed
@luthermonson luthermonson mentioned this pull request Mar 19, 2022
Merged
@philipgough philipgough mentioned this pull request Mar 24, 2022
Closed
@PhilYue PhilYue mentioned this pull request May 15, 2022
Closed
@hasan4791 hasan4791 mentioned this pull request Sep 27, 2022
Closed
fantapsody pushed a commit to fantapsody/cloud-on-k8s that referenced this pull request Feb 7, 2023
@naemono @fantapsody
Move fully to golang 1.17 (elastic#5271)
48d793c 
note: kubernetes-sigs/json#9
  We are using controller-tools v0.8.0, which includes this as a dependency
  which requires 1.17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@lavalamp lavalamp Awaiting requested review from lavalamp

Assignees

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Project support for Go 1.16
3 participants
@liggitt @k8s-ci-robot @deads2k