Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pinning sigs.k8s.io/json so go generate works on v1.17 go #2880

Merged
merged 1 commit into from
Mar 23, 2022

Conversation

luthermonson
Copy link
Contributor

Problem:

~\r\rke [pin-kdm] > go generate
# sigs.k8s.io/json/internal/golang/encoding/json
..\..\go\pkg\mod\sigs.k8s.io\json@v0.0.0-20211020170558-c049b76a60c6\internal\golang\encoding\json\encode.go:1249:12: sf.IsExported undefined (type reflect.StructField has no field or method IsExported)
..\..\go\pkg\mod\sigs.k8s.io\json@v0.0.0-20211020170558-c049b76a60c6\internal\golang\encoding\json\encode.go:1255:18: sf.IsExported undefined (type reflect.StructField has no field or method IsExported)
main.go:2: running "go": exit status 2

Fix: kubernetes-sigs/json#9

~\r\rke [release/v1.3] > go mod tidy
~\r\rke [release/v1.3] > go generate
Writing data
~\r\rke [release/v1.3] > go version
go version go1.17.8 windows/amd64

@rancherbot rancherbot added the status/auto-approved Auto approved by rancherbot label Mar 19, 2022
Copy link
Collaborator

@rancherbot rancherbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving pull request because all files are whitelisted for auto approval

@luthermonson luthermonson requested a review from kinarashah March 19, 2022 16:38
@luthermonson luthermonson merged commit 218adab into rancher:release/v1.3 Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/auto-approved Auto approved by rancherbot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants