Bump Dashboard to Dapr 1.13 and recent client-go #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Manuel Zapf <me@manuelzapf.io>
yaron2
reviewed
Jul 16, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #276 +/- ##
==========================================
+ Coverage 27.84% 27.93% +0.08%
==========================================
Files 7 7
Lines 801 802 +1
==========================================
+ Hits 223 224 +1
Misses 554 554
Partials 24 24 ☔ View full report in Codecov by Sentry. |
yaron2
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the current Dashboard version, I came across an issue. Once a sidecar had the
--enable-api-loggingflag set, It wouldn't show up in the dashboard anymore because of an issue in the dependency code of Dapr CLI with version 1.10. To fix that, I bumped the dependencies and the related dependencies.Since this is my first PR, happy to walk it through with the maintainers team to learn.