Specifying Kafka version as 1.0.0 in Note for Kafka with EH #3474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Deepanshu Agarwal <deepanshu.agarwal1984@gmail.com>
msfussell
reviewed
May 31, 2023
daprdocs/content/en/reference/components-reference/supported-bindings/kafka.md
Outdated
Show resolved
Hide resolved
msfussell
reviewed
May 31, 2023
daprdocs/content/en/reference/components-reference/supported-pubsub/setup-apache-kafka.md
Outdated
Show resolved
Hide resolved
msfussell
reviewed
May 31, 2023
daprdocs/content/en/reference/components-reference/supported-pubsub/setup-apache-kafka.md
Outdated
Show resolved
Hide resolved
|
@DeepanshuA - Left you some feedback |
Signed-off-by: Deepanshu Agarwal <deepanshu.agarwal1984@gmail.com>
Correct. We had a conversation on the same lines. |
|
@mukundansundar - Are you good here with this PR? Do you want to add any changes? Would like to get this merged. |
From a user perspective if we can add a back link from EH docs to Kafka pointing that EH can be used with Kafka component, it would be good. |
dnwe
added a commit
to dnwe/components-contrib
that referenced
this pull request
Aug 29, 2023
Also pin to v1.37.2 as that shouldn't be necessary since dapr/docs#3474 added documentation to add a version pin for Azure EventHubs users. Note: the module path has changed to github.com/IBM/sarama since ownership transitioned away from Shopify Fixes dapr#3104 Signed-off-by: Dominic Evans <dominic.evans@uk.ibm.com>
3 tasks
dnwe
added a commit
to dnwe/components-contrib
that referenced
this pull request
Aug 29, 2023
Also remove old module replace pin to v1.37.2 as that shouldn't be necessary since dapr/docs#3474 added documentation to add a config version pin for Azure EventHubs users instead. Note: the module path has changed to github.com/IBM/sarama since ownership transitioned away from Shopify Fixes dapr#3104 Signed-off-by: Dominic Evans <dominic.evans@uk.ibm.com>
dnwe
added a commit
to dnwe/components-contrib
that referenced
this pull request
Aug 30, 2023
Pulling in `fix(client): force Event Hubs to use V1_0_0_0` by @dnwe in IBM/sarama#2633 This should avoid dapr hitting any issues with Azure Event Hubs users who might not have followed the instructions in dapr/docs#3474 to pin their version number. Signed-off-by: Dominic Evans <dominic.evans@uk.ibm.com>
3 tasks
dnwe
added a commit
to dnwe/components-contrib
that referenced
this pull request
Aug 30, 2023
Pulling in `fix(client): force Event Hubs to use V1_0_0_0` by @dnwe in IBM/sarama#2633 This should avoid dapr hitting any issues with Azure Event Hubs users who might not have followed the instructions in dapr/docs#3474 to pin their version number. Signed-off-by: Dominic Evans <dominic.evans@uk.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for helping make the Dapr documentation better!
Please follow this checklist before submitting:
In addition, please fill out the following to help reviewers understand this pull request:
Description
Issue reference
Please reference the issue this PR will close: dapr/components-contrib#2874