-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding get actor reminder API in docs #1113
Merged
+10
−0
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Personal preference, we should include this with an input string as an example. Otherwise people may think it can only take hardcoded names.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I kept this as to be consistent with other APIs where the reminder-name is hardcoded in
RegisterReminder
andUnregisterReminder
. Both of them take the reminder name as inputs as well, similar toGetReminder
.https://github.com/dapr/dotnet-sdk/pull/1113/files/53876be8bf17e98bb9011094ab39623dc0be74e4#diff-763693d0f8815d098d3c9e4f284e8909335c17756bf549eef7abc550c3151a63L213
https://github.com/dapr/dotnet-sdk/pull/1113/files/53876be8bf17e98bb9011094ab39623dc0be74e4#diff-763693d0f8815d098d3c9e4f284e8909335c17756bf549eef7abc550c3151a63L225
It's also same as kept in examples: https://github.com/dapr/dotnet-sdk/blob/master/test/Dapr.E2E.Test.App/Actors/ReminderActor.cs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this okay @halspang ?