Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add lint in prs #175

Closed
wants to merge 5 commits into from
Closed

ci: add lint in prs #175

wants to merge 5 commits into from

Conversation

daixiang0
Copy link
Member

@daixiang0 daixiang0 commented Jun 16, 2021

Signed-off-by: Long Dai long0dai@foxmail.com

Fix #168

Changes as below:

  • add golangci-lint config
  • upgrade version to latest
  • fix lint issues by defaults

@daixiang0 daixiang0 force-pushed the golang branch 2 times, most recently from de5cfcf to 3b52774 Compare June 16, 2021 01:11
@daixiang0
Copy link
Member Author

@berndverst @yaron2 please review

@yaron2
Copy link
Member

yaron2 commented Jun 24, 2021

Please resolve conflicts.

@codecov
Copy link

codecov bot commented Jun 25, 2021

Codecov Report

Merging #175 (910bc2c) into main (994f9b6) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #175   +/-   ##
=======================================
  Coverage   76.11%   76.11%           
=======================================
  Files          14       14           
  Lines         603      603           
=======================================
  Hits          459      459           
  Misses         90       90           
  Partials       54       54           
Impacted Files Coverage Δ
service/http/invoke.go 78.57% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 994f9b6...910bc2c. Read the comment docs.

@daixiang0
Copy link
Member Author

@yaron2 done.

@daixiang0 daixiang0 force-pushed the golang branch 4 times, most recently from 0e54f14 to e846081 Compare June 25, 2021 06:07
Signed-off-by: Long Dai <long0dai@foxmail.com>
@daixiang0
Copy link
Member Author

ping @artursouza @yaron2

Copy link
Member

@artursouza artursouza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yaron2 Please, review as a maintainer.

@daixiang0 daixiang0 requested a review from a team as a code owner September 15, 2021 01:04
@daixiang0
Copy link
Member Author

ping @yaron2

@daixiang0 daixiang0 closed this Sep 30, 2021
@daixiang0 daixiang0 deleted the golang branch September 30, 2021 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce golangci-lint
3 participants