-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#815 Upgrade and fix issues for new Reactor version. #828
Conversation
fix checkstyle add missing space Initial commit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Upgrading it breaks the integration tests. There might be more dependencies to update because of this.
Will upgrade to spring boot 3.0.2 and see how it will go. |
Codecov Report
@@ Coverage Diff @@
## master #828 +/- ##
============================================
- Coverage 77.92% 77.91% -0.02%
Complexity 1260 1260
============================================
Files 116 116
Lines 3892 3889 -3
Branches 458 458
============================================
- Hits 3033 3030 -3
Misses 627 627
Partials 232 232
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
I created #830, that allows to use reactor only upgrading this dependency. In order to get closer to Spring Boot 3, i also propose #831 to upgrade to the latest version 2 of Spring boot. Both PR are passing integration tests and validation in my account (https://github.com/champel/dapr-java-sdk/pulls). @MatejNedic and me are working in a project where we have migrated to Spring Boot 3 but we want still to use the awesome dapr. |
@champel from what I have seen to bump version of spring boot 3.0 in this PR it will require changing some code since with Java 17 I had build issues inside this repository. |
@MatejNedic , the pipeline is building with versions 11,13,15 and 16. So I downgraded my local version to 11 to build the sdk. |
Closing in favour of #830 |
Description
Solves #815
Issue reference
#815
Please reference the issue this PR will close: #[issue number]
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: