Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(proto): update protos and point Workflow to beta APIs #531

Merged
merged 2 commits into from
Oct 13, 2023

Conversation

DeepanshuA
Copy link
Contributor

@DeepanshuA DeepanshuA commented Oct 13, 2023

Description

Updates dapr 1.12 protos and uses beta endpoint of wf http.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #[issue number]

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

Signed-off-by: Deepanshu Agarwal <deepanshu.agarwal1984@gmail.com>
@DeepanshuA DeepanshuA requested review from a team as code owners October 13, 2023 07:03
@shubham1172 shubham1172 changed the title proto updation and beta endpoint for wf http chore(proto): update protos and point Workflow to beta APIs Oct 13, 2023
Signed-off-by: Deepanshu Agarwal <deepanshu.agarwal1984@gmail.com>
@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

Attention: 243 lines in your changes are missing coverage. Please review.

Comparison is base (55f1673) 35.34% compared to head (fd2a47b) 35.10%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #531      +/-   ##
==========================================
- Coverage   35.34%   35.10%   -0.25%     
==========================================
  Files          90       90              
  Lines       10187    10460     +273     
  Branches      429      429              
==========================================
+ Hits         3601     3672      +71     
- Misses       6516     6718     +202     
  Partials       70       70              
Files Coverage Δ
src/proto/dapr/proto/runtime/v1/dapr_grpc_pb.js 5.82% <ø> (ø)
src/implementation/Client/HTTPClient/workflow.ts 12.69% <0.00%> (ø)
src/proto/dapr/proto/common/v1/common_pb.js 29.77% <25.00%> (-0.06%) ⬇️
src/proto/dapr/proto/runtime/v1/appcallback_pb.js 51.24% <16.66%> (-0.05%) ⬇️
src/proto/dapr/proto/runtime/v1/dapr_pb.js 30.20% <24.75%> (-0.20%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shubham1172 shubham1172 linked an issue Oct 13, 2023 that may be closed by this pull request
@shubham1172 shubham1172 merged commit e3987b7 into dapr:main Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Workflow management APIs to use beta instead of alpha
2 participants