fix flaky integration test DemoActorReminderOnceImpl #553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #553 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 6 6
Branches 1 1
=========================================
Hits 6 6 ☔ View full report in Codecov by Sentry. |
|
Thank you so much for looking into this @MregXN, these improvements will go a long way in increasing the SDK e2e test stability. |
MregXN
force-pushed
the
fix-flaky-integration-test-DemoActorReminderOnceImpl
branch
2 times, most recently
from
f485b55
to
9be2f50
Compare
MregXN
force-pushed
the
fix-flaky-integration-test-DemoActorReminderOnceImpl
branch
from
9be2f50
to
66d4bd0
Compare
Signed-off-by: MregXN <mregxn@gmail.com>
Signed-off-by: MregXN <mregxn@gmail.com>
Signed-off-by: MregXN <mregxn@gmail.com>
MregXN
force-pushed
the
fix-flaky-integration-test-DemoActorReminderOnceImpl
branch
from
7dbbad3
to
522f635
Compare
Signed-off-by: MregXN <mregxn@gmail.com>
MregXN
force-pushed
the
fix-flaky-integration-test-DemoActorReminderOnceImpl
branch
from
efc6c98
to
db46fa3
Compare
shubham1172
reviewed
Nov 22, 2023
Signed-off-by: MregXN <mregxn@gmail.com>
|
ready to review |
shubham1172
approved these changes
Nov 27, 2023
MregXN
deleted the
fix-flaky-integration-test-DemoActorReminderOnceImpl
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
it fails due to the following log
the
periodshould be able to be undefined.Issue reference
Please refer to the the point 4 of issue #7128 in dapr/dapr.