Fixes Actor Reminder Incorrect Period (#272)

* Fixes Actor Reminder Incorrect Period * update reminder data tests Co-authored-by: Bernd Verst <me@bernd.dev>
dapr · Sep 8, 2021 · aba8ed4 · aba8ed4
1 parent 04d8389
commit aba8ed4
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 9 deletions.
diff --git a/dapr/actor/runtime/_reminder_data.py b/dapr/actor/runtime/_reminder_data.py
@@ -74,7 +74,7 @@ def as_dict(self) -> Dict[str, Any]:
         return {
             'reminderName': self._reminder_name,
             'dueTime': self._due_time,
-            'period': self._due_time,
+            'period': self._period,
             'data': encoded_state.decode("utf-8"),
         }
 

diff --git a/setup.cfg b/setup.cfg
@@ -22,7 +22,7 @@ packages = find_namespace:
 include_package_data = True
 zip_safe = False
 install_requires =
-    protobuf == 3.13.0
+    protobuf == 3.17.3
     grpcio >= 1.26.0
     aiohttp >= 3.6.2
     python-dateutil >= 2.8.1

diff --git a/tests/actor/test_reminder_data.py b/tests/actor/test_reminder_data.py
@@ -18,11 +18,11 @@ def test_invalid_state(self):
                 'test_reminder',
                 123,  # int type
                 timedelta(seconds=1),
-                timedelta(seconds=1))
+                timedelta(seconds=2))
             ActorReminderData(
                 'test_reminder',
                 'reminder_state',  # string type
-                timedelta(seconds=1),
+                timedelta(seconds=2),
                 timedelta(seconds=1))
 
     def test_valid_state(self):
@@ -31,30 +31,30 @@ def test_valid_state(self):
             'test_reminder',
             b'reminder_state',
             timedelta(seconds=1),
-            timedelta(seconds=1))
+            timedelta(seconds=2))
         self.assertEqual(b'reminder_state', reminder.state)
 
     def test_as_dict(self):
         reminder = ActorReminderData(
             'test_reminder',
             b'reminder_state',
             timedelta(seconds=1),
-            timedelta(seconds=1))
+            timedelta(seconds=2))
         expected = {
             'reminderName': 'test_reminder',
             'dueTime': timedelta(seconds=1),
-            'period': timedelta(seconds=1),
+            'period': timedelta(seconds=2),
             'data': 'cmVtaW5kZXJfc3RhdGU=',
         }
         self.assertDictEqual(expected, reminder.as_dict())
 
     def test_from_dict(self):
         reminder = ActorReminderData.from_dict('test_reminder', {
             'dueTime': timedelta(seconds=1),
-            'period': timedelta(seconds=1),
+            'period': timedelta(seconds=2),
             'data': 'cmVtaW5kZXJfc3RhdGU=',
         })
         self.assertEqual('test_reminder', reminder.reminder_name)
         self.assertEqual(timedelta(seconds=1), reminder.due_time)
-        self.assertEqual(timedelta(seconds=1), reminder.period)
+        self.assertEqual(timedelta(seconds=2), reminder.period)
         self.assertEqual(b'reminder_state', reminder.state)