Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InvariantCulture to fix localization #1053

Merged
merged 3 commits into from
Jul 31, 2024
Merged

Conversation

erwinkramer
Copy link
Contributor

Description

Use InvariantCulture to fix localization.

Or else you get (on non-US):

== APP == insert into orders (orderid, customer, price) values (1, 'John Smith', 100,32);
== APP == fail: Microsoft.AspNetCore.Diagnostics.DeveloperExceptionPageMiddleware[1]
== APP ==       An unhandled exception has occurred while executing the request.
== APP ==       Dapr.DaprException: Binding operation failed: the Dapr endpoint indicated a failure. See InnerException for details.
== APP ==        ---> Grpc.Core.RpcException: Status(StatusCode="Internal", Detail="error invoking output binding sqldb: error executing query: ERROR: INSERT has more expressions than target columns (SQLSTATE 42601)")`

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • The quickstart code compiles correctly
  • You've tested new builds of the quickstart if you changed quickstart code
  • You've updated the quickstart's README if necessary
  • If you have changed the steps for a quickstart be sure that you have updated the automated validation accordingly. All of our quickstarts have annotations that allow them to be executed automatically as code. For more information see mechanical-markdown. For user guide with examples see Examples.

@erwinkramer erwinkramer force-pushed the master branch 2 times, most recently from 4496d35 to 9d5e9f9 Compare July 20, 2024 14:32
Signed-off-by: Erwin Kramer <r3verse@gmail.com>
Signed-off-by: Erwin Kramer <r3verse@gmail.com>
Signed-off-by: Erwin Kramer <r3verse@gmail.com>
@paulyuk paulyuk changed the base branch from master to release-1.14 July 28, 2024 18:58
@paulyuk paulyuk requested review from a team as code owners July 28, 2024 18:58
@paulyuk paulyuk self-requested a review July 28, 2024 18:58
@paulyuk paulyuk added this to the 1.14 milestone Jul 28, 2024
Copy link
Contributor

@paulyuk paulyuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for contribution and adjustments to the builder. Running tests now against release-1.14 so we can take it there.

@paulyuk paulyuk closed this Jul 29, 2024
@paulyuk paulyuk reopened this Jul 29, 2024
@paulyuk
Copy link
Contributor

paulyuk commented Jul 29, 2024

closed and reopened to retest on rebase of release-1.14 branch

@paulyuk
Copy link
Contributor

paulyuk commented Jul 31, 2024

This only affects C# quickstarts, and those checks pass. I'm merging.

@paulyuk paulyuk merged commit a5e8f5d into dapr:release-1.14 Jul 31, 2024
10 of 13 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

3 participants