-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating Readme to favor kubectl based deploy vs. multi app run #1057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…his release Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>
…t should not try to add or delete the redis.yaml crd Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>
msfussell
reviewed
Jul 23, 2024
|
||
```bash | ||
component.dapr.io/statestore created | ||
dapr-dashboard dapr-system True Running 1 0.14.0 41s 2024-07-22 13:53.05 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This output is now different in v1.14 is this matters. See dapr/cli#1434
Need to add the scheduler service
msfussell
previously approved these changes
Jul 23, 2024
Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>
Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>
Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>
… into hello-k8s-single-run
Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>
Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>
…-k8s-single-run Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>
Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>
We should take this fix
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Multi-app run has some challenges for multiple services where dependencies and timing is important, per #1048.
For this release we will keep
dapr init -k --dev
step in tutorial, but we will revert back to using kubectl commands for deployment../deploy/redis.yaml
installed astatestore
component crd to kubernetes explicitly. It also deletes it. So I now delete this file from ./deploy to let the Dapr CLI handle this component, and this prevents the test from deleting the CRD as a part of deleting all deployments from .deploy, which would permanently break your dev/test environment.Issue reference
Please reference the issue this PR will close: #1048
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: