Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating dockerfiles used in Tutorial make build (C#,Python,Node,ReactClient) #1062

Merged
merged 3 commits into from
Jul 24, 2024

Conversation

paulyuk
Copy link
Contributor

@paulyuk paulyuk commented Jul 24, 2024

Description

Updating tools chains in dockerfiles to:

  • use latest of each language stack's SDK that is compatible with app
  • multi stage build in .net for performance and size
  • build and test clean with make build in each tutorial folder
  • leveraged by build.yaml github action workflow

Issue reference

This is a companion fix to #1058 for the other languages

Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>
…for dist calculator already fixed by dapr#1058

Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>
@paulyuk paulyuk added dependencies Pull requests that update a dependency file P1 area/tutorials labels Jul 24, 2024
@paulyuk paulyuk added this to the 1.14 milestone Jul 24, 2024
@paulyuk paulyuk self-assigned this Jul 24, 2024
@paulyuk paulyuk added the build label Jul 24, 2024
…citly expose port

Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>
@paulyuk paulyuk requested a review from msfussell July 24, 2024 08:47
@paulyuk
Copy link
Contributor Author

paulyuk commented Jul 24, 2024

I tested every dockerfile's build at runtime to ensure compat.

Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaron2 yaron2 merged commit 4f59e09 into dapr:master Jul 24, 2024
5 of 7 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/tutorials build dependencies Pull requests that update a dependency file P1
Projects
Development

Successfully merging this pull request may close these issues.

3 participants