Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: validate_tutorials #1069

Merged
merged 5 commits into from
Jul 25, 2024
Merged

fix: validate_tutorials #1069

merged 5 commits into from
Jul 25, 2024

Conversation

mikeee
Copy link
Member

@mikeee mikeee commented Jul 25, 2024 •
edited
Loading

Description

  • Renames the tutorials validation workflow to validate_tutorials.yaml
  • Bumps kind & kubernetes to more recent, supported versions and image tag.
  • Defines a global resiliency policy
  • Updates dapr returned endpoints
  • Adds some timings to allow for metrics to propagate before validation takes place

Issue reference

CLI related issue: 1436

We strive to have all PRs being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #[issue number]

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • The quickstart code compiles correctly
  • You've tested new builds of the quickstart if you changed quickstart code
  • You've updated the quickstart's README if necessary
  • If you have changed the steps for a quickstart be sure that you have updated the automated validation accordingly. All of our quickstarts have annotations that allow them to be executed automatically as code. For more information see mechanical-markdown. For user guide with examples see Examples.

@mikeee mikeee changed the base branch from master to release-1.14 July 25, 2024 10:19
mikeee added 2 commits July 25, 2024 11:55
@mikeee
ci: remove debug/log step
ff7603a 
Signed-off-by: mikeee <hey@mike.ee>
@mikeee
fix: define resiliency policy
231fb83 
Signed-off-by: mikeee <hey@mike.ee>
@mikeee mikeee force-pushed the validate-tutorials branch from 9482dcb to 231fb83 Compare July 25, 2024 12:46
@mikeee
fix: update expected validation output
afdd5ea 
Signed-off-by: mikeee <hey@mike.ee>
@mikeee mikeee changed the title Validate tutorials fix: validate_tutorials Jul 25, 2024
@mikeee mikeee requested a review from paulyuk July 25, 2024 20:24
@mikeee mikeee marked this pull request as ready for review July 25, 2024 20:31
paulyuk
paulyuk approved these changes Jul 25, 2024
View reviewed changes
Copy link
Contributor

@paulyuk paulyuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thank you for fixing tutorials!! this has been a long road.

.github/workflows/validate_tutorials.yaml
KIND_VERSION: v0.12.0
KIND_IMAGE_SHA: sha256:69860bda5563ac81e3c0057d654b5253219618a22ec3a346306239bba8cfa1a6
GOVER: 1.22
KUBERNETES_VERSION: v1.29.4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

modern kubernetes and kind versions. check!

tutorials/observability/README.md
@@ -389,6 +389,8 @@ expected_stdout_lines:
- '"total":"54"'
output_match_mode: substring
name: "Curl test"
background: false
sleep: 5
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, this makes more resilient for timing issues in the runner

@paulyuk paulyuk merged commit 68dc3d3 into dapr:release-1.14 Jul 25, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulyuk paulyuk paulyuk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikeee @paulyuk