Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sdkversionchange #950

Merged
merged 3 commits into from
Oct 13, 2023
Merged

Sdkversionchange #950

merged 3 commits into from
Oct 13, 2023

Conversation

rabollin
Copy link
Contributor

@rabollin rabollin commented Oct 13, 2023

Changed DAPR & CLI version to point to latest released version, also modified Go & Java SDK version to latest released version.

Please explain the changes you've made

Issue reference

We strive to have all PRs being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: endgame

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • The quickstart code compiles correctly
  • You've tested new builds of the quickstart if you changed quickstart code
  • You've updated the quickstart's README if necessary
  • If you have changed the steps for a quickstart be sure that you have updated the automated validation accordingly. All of our quickstarts have annotations that allow them to be executed automatically as code. For more information see mechanical-markdown. For user guide with examples see Examples.

Signed-off-by: rabollin <rabollin@microsoft.com>
Signed-off-by: rabollin <rabollin@microsoft.com>
Signed-off-by: rabollin <rabollin@microsoft.com>
@mukundansundar
Copy link
Contributor

@dapr/maintainers-quickstarts Please review this PR.

@paulyuk paulyuk self-assigned this Oct 13, 2023
@paulyuk
Copy link
Contributor

paulyuk commented Oct 13, 2023

taking it

Copy link
Contributor

@paulyuk paulyuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for this @rabollin .

Note we need one more PR still for js-sdk updates.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm just double checking with @yaron2 that line 34 dependency on rc1 for protobuf makes sense.
google.golang.org/protobuf v1.26.0-rc.1/go.mod h1:jlhhOSvTdKEhbULTjvd4ARK9grFBp09yW+WbY/TyQbw=

@paulyuk
Copy link
Contributor

paulyuk commented Oct 13, 2023

I'm going to take this now to unblock train. If @yaron2 wants us to fix protobuf dependencies I'll do that in another PR.

@paulyuk paulyuk merged commit 4d447df into dapr:release-1.12 Oct 13, 2023
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants